Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slideshow controls can be killed by a single image #246

Closed
oparoz opened this issue Jul 27, 2015 · 3 comments
Closed

Slideshow controls can be killed by a single image #246

oparoz opened this issue Jul 27, 2015 · 3 comments
Milestone

Comments

@oparoz
Copy link
Contributor

oparoz commented Jul 27, 2015

Steps to reproduce

  1. Create a folder and put a single image in it
  2. Switch to Gallery view
  3. Start the slideshow

Expected result

The picture should be shown and the play/pause controls should not appear

Actual result

Both the play and pause icons are shown and they overlap each other
Clicking on them will make them disappear and it won't be possible to use the slideshow any more until a full refresh is performed.

@oparoz oparoz added the bug label Jul 27, 2015
@oparoz oparoz added this to the 8.2-current milestone Jul 27, 2015
@oparoz oparoz added the design label Jul 27, 2015
@oparoz
Copy link
Contributor Author

oparoz commented Jul 27, 2015

@jancborchardt

@jancborchardt
Copy link
Member

Next to the play/pause being hidden, the next/previous should also not be shown, right?

Can you check if it’s the only image in that folder and then deactivate the buttons? Add a class .hidden to them, and it should be handled via CSS.

@oparoz
Copy link
Contributor Author

oparoz commented Jul 28, 2015

The code to hide stuff is already there, but it doesn't work.
https://github.com/owncloud/gallery/blob/master/js/slideshowcontrols.js#L59-L61

@oparoz oparoz closed this as completed in fcfec95 Jul 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants