Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to configure pollinterval capability to control desktop and iOS app #109

Open
2 of 12 tasks
michaelstingl opened this issue Aug 27, 2021 · 13 comments
Open
2 of 12 tasks

Comments

@michaelstingl
Copy link
Contributor

WHAT Needs to be Documented?

How to configure pollinterval capability

WHERE Does This Need To Be Documented (Link)?

https://doc.owncloud.com/server/admin_manual/

WHY Should This Change Be Made?

It's currently not documented

(Optional) What Type Of Content Change Is This?

  • New Content Addition
  • Old Content Deprecation
  • Existing Content Simplification
  • Bug Fix to Existing Content

(Optional) Which Manual Does This Relate To?

  • Admin Manual
  • Developer Manual
  • User Manual
  • Android
  • iOS
  • Branded Clients
  • Desktop Client
  • Other

Related:

@mmattel
Copy link
Contributor

mmattel commented Aug 27, 2021

@michaelstingl Q: as this adresses an addon in the admin section of core, this means there must be a config option to be set in core which is then delivered via the capabilities to the requestor. Can you please clarify this new core config option?

@michaelstingl
Copy link
Contributor Author

there must be a config option to be set in core

I only see it's exposed via /ocs/v1.php/cloud/capabilities (https://doc.owncloud.com/server/developer_manual/core/apis/ocs-capabilities.html), but I have no idea how to set it. (I didn't see it in admin UI). Maybe occ command or config.php

@mmattel
Copy link
Contributor

mmattel commented Aug 27, 2021

hmmm, my points around this are the following:

  1. if there is no config option already available which can be tuned, only the standard value - wherever it comes from - will be taken
  2. in case of (1), a new config option must be implemented and a process behind generated to expose this option to the capabilities. This addresses a change in core.
  3. if there is a config option already available, please name it so I can progress.

After looking into config.sample and the occ commands, I have not identified any options to be set or occ command to be used to change the polling interval values - but I may be wrong.

To proceed here, details are necessary which I do not have. Therefore my request for clarification.

I am adding @dragotin, maybe he knows more or can initiate a change in core.

@jnweiger
Copy link
Contributor

For testing, I edited config/config.php and did

image

This sets the poll interval of the desktop client effectively to 122 seconds. Not sure, if there is more in the admin UI.

@michaelstingl
Copy link
Contributor Author

For testing, I edited config/config.php

yes, this seems to work

@mmattel
Copy link
Contributor

mmattel commented Aug 27, 2021

https://github.com/owncloud/client/pull/8777/files#diff-2aad484333f0fe726172ec93e683428a6919aaf5e1684dbeaf7e236b60886dd4
Line 418

    // The server default-capabilities is set to 60, which is, if interpreted in milliseconds,
    // pretty small. If the value is above 5 seconds, it was set intentionally.
    // Server admins have to set the value in Milliseconds!

@dragotin
Copy link

This feature was done in owncloud/client#8777 and I apologize to not bring it up here properly, even though people asked me to.

There is no admin UI for that. It can only be adjusted by editing the config.php so far. It allows admins to change the desktop client check frequency for changes on the cloud. And with that, it only influences the maximum time that it takes until changes in the cloud are propagated to clients.

Example: If that is set to 45000 it takes up to 45 seconds until the client "sees" a change on the server and syncs that to the client. In cases where there is little sharing (ie. in typical private photo clouds or so) that does not have a big impact.

We changed the unit from seconds to milliseconds to make sure the client does not pick up a value from old servers which was 60 IIRC. So now the value has to be given in milliseconds, and everything below 5000 is ignored.

@phil-davis phil-davis transferred this issue from owncloud/docs Feb 22, 2022
@phil-davis
Copy link
Contributor

I have documented by:

  1. adjusting the existing developer docs (PR Adjust pollinterval in docs #110 )
  2. adding to config.sample.php in core PR default pollinterval 30000 msec core#39143 - that will come to here in a config-to-docs run

Is another descriptive section needed for this somewhere in the admin docs? Or?

@mmattel
Copy link
Contributor

mmattel commented Feb 23, 2022

Btw, the desktop and ios is mentioned, what about android? Is it implemented there?
Adding @jesmrec maybe he knows more

@jesmrec
Copy link

jesmrec commented Feb 24, 2022

Polling interval is not developed in Android yet.

@JRundfeldt
Copy link

The Docs need the info when the clients get the new value - immediatly? at the next request? at login? after reboot of a client system?

@phil-davis
Copy link
Contributor

The server provides the value whenever it is asked. The docs of each client would need to be enhanced to say when the client checks/rechecks that capability (or, for example, on Android add documentation to say that the setting is ignored)

@jnweiger
Copy link
Contributor

In 10.10.0 rc2 the capabilities say pollinterval 30000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants