Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]added then steps for apiShareCreateSpecialToRoot1 suite #39861

Merged
merged 3 commits into from
Apr 6, 2022
Merged

[tests-only][full-ci]added then steps for apiShareCreateSpecialToRoot1 suite #39861

merged 3 commits into from
Apr 6, 2022

Conversation

sushmita56
Copy link
Contributor

@sushmita56 sushmita56 commented Mar 10, 2022 •
edited by kiranparajuli589
Loading

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suite Covered

  • apiShareCreateSpecialToRoot1
  • apiShareCreateSpecialToShares1/createShareReceivedInMultipleWays.feature

Related Issues

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Mar 10, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sushmita56 sushmita56 changed the title added then steps for apiShareCreateSpecialToRoot1 suite [tests-only][full-ci]added then steps for apiShareCreateSpecialToRoot1 suite Mar 10, 2022
@sushmita56 sushmita56 self-assigned this Mar 10, 2022
@sushmita56 sushmita56 mentioned this pull request Mar 10, 2022
Closed
kiranparajuli589
kiranparajuli589 previously requested changes Mar 10, 2022
View reviewed changes
tests/acceptance/features/apiShareCreateSpecialToRoot1/createShareExpirationDate.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiShareCreateSpecialToRoot1/createShareExpirationDate.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiShareCreateSpecialToRoot1/createShareExpirationDate.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiShareCreateSpecialToRoot1/createShareExpirationDate.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiShareCreateSpecialToRoot1/createShareUniqueReceivedNames.feature Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/AppConfigurationContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
@sushmita56 sushmita56 force-pushed the then-steps-in-apiShareCreateSpecialToRoot1 branch from 7f91db8 to a532a84 Compare March 11, 2022 04:19
grgprarup
grgprarup reviewed Mar 11, 2022
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be made

@sushmita56 sushmita56 force-pushed the then-steps-in-apiShareCreateSpecialToRoot1 branch from a532a84 to 61430e1 Compare March 11, 2022 10:57
@kiranparajuli589
Copy link
Contributor

@sushmita56 @grgprarup these discussed tests mostly involves

  • admin set some config (definitely given step)
  • user creates a share (definitely given step)
  • admins change some config (i think this should be when, as this step is actually changing some state, which we want to react after)
  • user queries for the last share (this is just a helper to get data from the server for our then assertion, so if this can be handled from then step then it would be great.)
  • share details assertions (definitely then step)

any comments, thoughts? cc @phil-davis

@sushmita56 sushmita56 force-pushed the then-steps-in-apiShareCreateSpecialToRoot1 branch 2 times, most recently from 6d13990 to 61bf543 Compare March 14, 2022 11:16
@kiranparajuli589 kiranparajuli589 force-pushed the then-steps-in-apiShareCreateSpecialToRoot1 branch 2 times, most recently from 53d2a38 to 5b1cc9c Compare March 29, 2022 10:10
@kiranparajuli589 kiranparajuli589 force-pushed the then-steps-in-apiShareCreateSpecialToRoot1 branch 2 times, most recently from 41cebab to 222fbff Compare April 4, 2022 04:45
@kiranparajuli589 kiranparajuli589 force-pushed the then-steps-in-apiShareCreateSpecialToRoot1 branch from 222fbff to d2b6adb Compare April 4, 2022 08:14
individual-it
individual-it requested changes Apr 4, 2022
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pointed out some more cases where we should be keeping on using the original steps.
Why changing an existing nice Then step and splitting it into 3 When-Then-And steps

Same applies to a lot of other places in this PR

...acceptance/features/apiShareCreateSpecialToShares1/createShareReceivedInMultipleWays.feature Outdated Show resolved Hide resolved
...acceptance/features/apiShareCreateSpecialToShares1/createShareReceivedInMultipleWays.feature Outdated Show resolved Hide resolved
...acceptance/features/apiShareCreateSpecialToShares1/createShareReceivedInMultipleWays.feature Outdated Show resolved Hide resolved
...acceptance/features/apiShareCreateSpecialToShares1/createShareReceivedInMultipleWays.feature Outdated Show resolved Hide resolved
@kiranparajuli589 kiranparajuli589 force-pushed the then-steps-in-apiShareCreateSpecialToRoot1 branch 4 times, most recently from 031c90e to 94fa0c1 Compare April 4, 2022 13:14
@kiranparajuli589 kiranparajuli589 force-pushed the then-steps-in-apiShareCreateSpecialToRoot1 branch from 94fa0c1 to 32cba12 Compare April 4, 2022 13:22
@kiranparajuli589 kiranparajuli589 force-pushed the then-steps-in-apiShareCreateSpecialToRoot1 branch from 32cba12 to 1d7036b Compare April 4, 2022 18:19
sushmita56 and others added 3 commits April 5, 2022 13:11
@sushmita56 @kiranparajuli589
added then steps for apiShareCreateSpecialToRoot1 suite
006713b 
fixed php style

addressed review
@kiranparajuli589
Addressed reviews
8078e77 
Signed-off-by: Parajuli Kiran <[email protected]>
@kiranparajuli589
Adjust reviews in apiShareCreateSpecialToShares1/createShareReceivedI…
a17e280 
…nMultipleWays.feature

Signed-off-by: Parajuli Kiran <[email protected]>
Signed-off-by: Kiran Parajuli <[email protected]>
@kiranparajuli589 kiranparajuli589 force-pushed the then-steps-in-apiShareCreateSpecialToRoot1 branch from 1d7036b to a17e280 Compare April 5, 2022 08:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kiranparajuli589
Copy link
Contributor

@individual-it can you please have a look at this again.

@individual-it
Copy link
Member

@kiranparajuli589 LGTM, please squash the commits

@kiranparajuli589 kiranparajuli589 dismissed their stale review April 6, 2022 07:40

requested changes are already made

@kiranparajuli589 kiranparajuli589 merged commit 906c79a into master Apr 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the then-steps-in-apiShareCreateSpecialToRoot1 branch April 6, 2022 07:41
@kiranparajuli589 kiranparajuli589 mentioned this pull request Apr 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@grgprarup grgprarup grgprarup left review comments

@phil-davis phil-davis phil-davis left review comments

@individual-it individual-it individual-it approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@Talank Talank Awaiting requested review from Talank

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@sushmita56 sushmita56

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sushmita56 @kiranparajuli589 @phil-davis @individual-it @grgprarup @Talank @SagarGi @amrita-shrestha