Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oc-1949 - [ownCloud Server] Sharing link passwords in 4.5 RC3; expiration broken #890

Closed
msrex opened this issue Dec 14, 2012 · 1 comment

Comments

@msrex
Copy link

msrex commented Dec 14, 2012

From http://bugs.owncloud.org/thebuggenie/owncloud/issues/oc-1949

Confirmed with stable45 - the password is not required for downloading the file! It does not matter whether you press the enter key as suggested in #5 below.

Description:
I can't seem to get ownCloud to request a password on RC3 with public shared folders, even though I set one in the interface. I logged in, set the link and password. Opened a different browser, and the files just showed up with no password required.

Also, whenever I set a share expiration date I can no longer access the shared menu for any file or folder in the web interface (it breaks sharing?) for that user. If I log out and back in, it works and the expiration date is there appropriately set.

Reproduction steps:
Log in to ownCloud RC3. Create a bunch of users. Upload some files and share with those users. Set expiration: it creates the problem above. Try to set a password, log out and then use the share link and the password is not required.
#4 Comment posted by MTGap Oct 09, 20:24

I'm not able to reproduce any of these issues.

You have to hit enter after you type in a password and then it should say 'Password protected' inside the textbox. I'm not sure if this is the best user experience.
#5 Comment posted by MTRichards Oct 09, 20:34

So I can definitely get the password protection to work with the enter key pressed...that will cause some confusion as you don't always have to hit enter to do stuff in ownCloud, but it works.

The expiration date still has this problem for me in RC3. Are you using the latest stable version instead? It may very well be fixed...
#6 Comment posted byMTGap Oct 09, 23:24

Yes, I'm running 4.5 final. I don't think there is anything between RC3 and final that would've changed this.
#7 Comment posted by Björn Oct 10, 08:21

Also, whenever I set a share expiration date I can no longer access the shared menu for any file or folder in the web interface (it breaks sharing?) for that user. If I log out and back in, it works and the expiration date is there appropriately set.

I experienced a similar problem yesterday but it was fixed with one of the last commits dealing with the share dialog. Since about yesterday afternoon the problem no longer occurs on my system. Therefore I'm quite sure that it is fixed in the final 4.5.

It would be great if you could try if the issues still occur on your system with the final 4.5 version.

@LukasReschke
Copy link
Member

Should be fixed in since 4.5.3.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants