Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is failing #36322

Closed
phil-davis opened this issue Oct 23, 2019 · 2 comments · Fixed by #36423
Closed

CI is failing #36322

phil-davis opened this issue Oct 23, 2019 · 2 comments · Fixed by #36423
Assignees

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Oct 23, 2019

Steps to reproduce

  1. Run drone CI

Expected behaviour

Pass

Actual behaviour

  1. phpunit LargeFileHelper fails e.g. https://drone.owncloud.com/owncloud/core/20935/13/9
There were 2 failures:

1) Test\LargeFileHelperGetFileSizeTest::testGetFileSizeViaCurl with data set #0 ('/drone/src/tests/data/lorem.txt', 446)
Failed asserting that null is identical to 446.

/drone/src/tests/lib/LargeFileHelperGetFileSizeTest.php:53

2) Test\LargeFileHelperGetFileSizeTest::testGetFileSizeViaCurl with data set #1 ('/drone/src/tests/data/strängé...2).txt', 446)
Failed asserting that null is identical to 446.

/drone/src/tests/lib/LargeFileHelperGetFileSizeTest.php:53

on various PHP 7.0 and 7.1 unit test runs.

And fails on 7.2 https://drone.owncloud.com/owncloud/core/20935/21/9 and 7.3 https://drone.owncloud.com/owncloud/core/20935/23/9 but the drone job is green!?!?!?

  1. samba and SMB-windows unit tests fail
    https://drone.owncloud.com/owncloud/core/20935/26/10
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

Runtime:       PHPDBG 7.1.32-1+ubuntu18.04.1+deb.sury.org+1
Configuration: /drone/src/tests/phpunit-autotest-external.xml

mkdir failed on directory /var/cache/samba: Permission denied
mkdir failed on directory /var/cache/samba: Permission denied
mkdir failed on directory /var/cache/samba: Permission denied
Fmkdir failed on directory /var/cache/samba: Permission denied
...
There were 85 failures:

1) OCA\Files_External\Tests\Storage\SmbTest::testRenameWithSpaces
Failed asserting that false is true.

/drone/src/apps/files_external/tests/Storage/SmbTest.php:53
...

Server configuration

core master

@phil-davis
Copy link
Contributor Author

phil-davis commented Oct 23, 2019

PR #36318 demonstrates the fails.

PR #36319 fixes (1) the LargeFileHelper fails and disables the failing tests (2)

To do:

  • enable the samba and SMB-windows unit tests
  • make them pass in drone CI

@phil-davis
Copy link
Contributor Author

PR #36423 fixes the samba tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant