From 826d8f872808d905a724c361bcda80086c5a7d52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Pablo=20Villaf=C3=A1=C3=B1ez?= Date: Thu, 19 Dec 2019 09:11:49 +0100 Subject: [PATCH] Minor code style fixes --- apps/files/tests/js/filelistSpec.js | 12 ++++++------ apps/files_sharing/css/sharetabview.css | 3 +-- core/js/tests/specs/sharedialogviewSpec.js | 14 +++++++------- 3 files changed, 14 insertions(+), 15 deletions(-) diff --git a/apps/files/tests/js/filelistSpec.js b/apps/files/tests/js/filelistSpec.js index 317d41af5205..3c8e30724177 100644 --- a/apps/files/tests/js/filelistSpec.js +++ b/apps/files/tests/js/filelistSpec.js @@ -1034,14 +1034,14 @@ describe('OCA.Files.FileList tests', function() { }] } }); - fileList.setFiles(testFiles) - expect($('#fileList tr:first-of-type td .sharetree-item').length).toEqual(1) + fileList.setFiles(testFiles); + expect($('#fileList tr:first-of-type td .sharetree-item').length).toEqual(1); }); it('does not show shareTree items if shareTree is empty', function() { - fileList._purgeShareTreeCache() - fileList.setFiles(testFiles) - expect($('#fileList tr td .sharetree-item').length).toEqual(0) - }) + fileList._purgeShareTreeCache(); + fileList.setFiles(testFiles); + expect($('#fileList tr td .sharetree-item').length).toEqual(0); + }); }); describe('Filtered list rendering', function() { it('filters the list of files using filter()', function() { diff --git a/apps/files_sharing/css/sharetabview.css b/apps/files_sharing/css/sharetabview.css index 488e00423f8a..2a01409394ea 100644 --- a/apps/files_sharing/css/sharetabview.css +++ b/apps/files_sharing/css/sharetabview.css @@ -89,9 +89,8 @@ display: flex; justify-content: flex-start; align-items: center; - padding-top: 5px; - padding-bottom: 5px; + padding-bottom: 5px; } .shareTree-item * { diff --git a/core/js/tests/specs/sharedialogviewSpec.js b/core/js/tests/specs/sharedialogviewSpec.js index 271ec48c10d6..05324277639e 100644 --- a/core/js/tests/specs/sharedialogviewSpec.js +++ b/core/js/tests/specs/sharedialogviewSpec.js @@ -965,7 +965,7 @@ describe('OC.Share.ShareDialogView', function() { }); it('creates link share view only after selecting tab', function() { expect(dialog.$('.linkListView').is(':empty')).toEqual(true); - + dialog.$('.subTabHeaders>.subTabHeader:eq(1)').click(); expect(dialog.$('.linkListView').is(':empty')).toEqual(false); @@ -1001,18 +1001,18 @@ describe('OC.Share.ShareDialogView', function() { }] } }); - }) + }); afterEach(function() { fileList.destroy(); - $('#filelist').remove() + $('#filelist').remove(); }); it('renders parent user/groups shares', function() { - fileList._setShareTreeUserGroupView() + fileList._setShareTreeUserGroupView(); expect(dialog.$el.find('#shareTreeUserGroupList li').length).toEqual(4); - }) + }); it('renders parent link shares', function() { - fileList._setShareTreeLinkView() + fileList._setShareTreeLinkView(); expect(dialog.$el.find('#shareTreeLinkList li').length).toEqual(2); - }) + }); }); });