diff --git a/changelog/unreleased/36315 b/changelog/unreleased/36315
new file mode 100644
index 000000000000..51eef6cc0c9e
--- /dev/null
+++ b/changelog/unreleased/36315
@@ -0,0 +1,6 @@
+Fix links in setupchecks.js
+
+Security tips at Settings -> Admin -> General had two broken links to the owncloud docs in the messages performing HTTPS and HSTS checks
+
+https://github.com/owncloud/core/pull/36315
+https://github.com/owncloud/core/issues/36238
diff --git a/core/js/setupchecks.js b/core/js/setupchecks.js
index dc39ecf93971..0b27d1ff7a2d 100644
--- a/core/js/setupchecks.js
+++ b/core/js/setupchecks.js
@@ -272,6 +272,9 @@
var messages = [];
if (xhr.status === 200) {
+ var oc_defaults = oc_defaults || {};
+ var docPlaceholderUrl = oc_defaults.docPlaceholderUrl || '';
+
if(OC.getProtocol() === 'https') {
// Extract the value of 'Strict-Transport-Security'
var transportSecurityValidity = xhr.getResponseHeader('Strict-Transport-Security');
@@ -283,17 +286,20 @@
transportSecurityValidity = transportSecurityValidity.substring(8);
}
}
-
var minimumSeconds = 15552000;
if(isNaN(transportSecurityValidity) || transportSecurityValidity <= (minimumSeconds - 1)) {
messages.push({
- msg: t('core', 'The "Strict-Transport-Security" HTTP header is not configured to at least "{seconds}" seconds. For enhanced security we recommend enabling HSTS as described in our security tips.', {'seconds': minimumSeconds, docUrl: '#admin-tips'}),
+ msg: t('core',
+ 'The "Strict-Transport-Security" HTTP header is not configured to at least "{seconds}" seconds. For enhanced security we recommend enabling HSTS as described in our security tips.',
+ {'seconds': minimumSeconds, docUrl: docPlaceholderUrl.replace('PLACEHOLDER', 'enable-http-strict-transport-security')}),
type: OC.SetupChecks.MESSAGE_TYPE_WARNING
});
}
} else {
messages.push({
- msg: t('core', 'You are accessing this site via HTTP. We strongly suggest you configure your server to require using HTTPS instead as described in our security tips.', {docUrl: '#admin-tips'}),
+ msg: t('core',
+ 'You are accessing this site via HTTP. We strongly suggest you configure your server to require using HTTPS instead as described in our security tips.',
+ {docUrl: docPlaceholderUrl.replace('PLACEHOLDER', 'use-https')}),
type: OC.SetupChecks.MESSAGE_TYPE_WARNING
});
}