QtKeyhcain: DeletePasswordJob with KWallet does not delete, but creates an empty entry instead

[TheOneRing]

#9019 (comment)

I had a quick look:

2.8.1 creates a password entry in the format of username:https://host/:0 with the password, nothing else.

The 2.9 branch reads this, and then tries to delete a nonexistant username:https://host/ entry. For some reason (removeEntry seems to be dead code), QtKeychain instead calls writePassword with empty data, so it creates an empty entry instead of doing nothing...

On top of that QtKeychain bug there is another weirdness which I can't explain so far: The account is "offline" immediately after migration, and I need to restart the client to trigger a connection. Could be some missing signal emission or something like that.

Are you using the appimage? Where there warnings from qtkeychain?

[Vogtinator]

Are you using the appimage?

No, I built from the 2.9 branch manually, against libqt5keychain1-0.12.0-2.5.x86_64.

Where there warnings from qtkeychain?

Only Could not load qtkeychain translations

[TheOneRing]

So I had issues before but it turned out that my qtkeychain was build without support for lib secret.
08-20 13:35:43:674 [ debug default ] [ LibSecretKeyring::deletePassword ]: static bool LibSecretKeyring::deletePassword(const QString&, const QString&, QKeychain::JobPrivate*)

So the client switched between libsecret and gnome keything, and lost the pw on the way.

[Vogtinator]

I'm using kwallet and it's using the kwallet methods in qtkeychain properly.

My theory is that https://github.com/frankosterfeld/qtkeychain/blob/c729d0bc3a7d0932cbcacc773a98ea8660064fc0/keychain_unix.cpp#L520 is never reached because mode is always either Text or Binary. That's a bug which owncloud-client could only work around by just not attempting to delete keys unfortunately.

However, that might not be necessary because the old password is read properly before the old keys are "deleted", so the new entry can be written with the correct content at this point. With the new entry, the old entries not being deleted properly shouldn't matter anymore.

[TheOneRing]

Huh maybe time to open an issue in qtkeychain I didn't realise that this is an upstream issue before.

[Vogtinator]

Done: frankosterfeld/qtkeychain#199

Working around that in the client should be possible by not reading the old password twice

[github-actions]

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

[TheOneRing]

Fixed in 0.13.1.
Will be part of 2.10 for app images.
@fmoc anything needed for obs?

[TheOneRing]

frankosterfeld/qtkeychain#199