Implement local collissions following the ownCloud convention

[michaelstingl]

When local sync folders collide (re-adding the same Space, or syncing 2 Spaces with identical names), they should be created with " (2)" at the end. (Same as in other ownCloud products, for example when I receive 2 Shares with the same name.

[TheOneRing]

See

client/src/gui/folderman.cpp

Line 788 in 23bbc69

QString FolderMan::findGoodPathForNewSyncFolder(const QString &basePath, const QString &newFolder) const

[Salipa-Gurung]

Tested with
Desktop client version ownCloud 5.0.0.11822-daily20230821 65017f
windows-10.0.19045

Syncing 2 spaces with same name, one space is created with (2) at the end. ✔️

[HanaGemela]

@michaelstingl haven't you meant the Space name?

[michaelstingl]

@michaelstingl haven't you meant the Space name?

No, only collision of local sync folders

[Salipa-Gurung]

Tested with
Desktop client version ownCloud 5.0.0.11822-daily20230821 65017f
windows-10.0.19045

For 2 shares with same name

Before force sync

• one share(test-share) is synced locally

• but in another share(test-share(1)) error occurs: Error transferring https://192.168.56.1:9200/dav/spaces/a0ca6a90-a365-4782-871e-d44447bbc668$a0ca6a90-a365-4782-871e-d44447bbc668/test-share (1) - server replied: Not Found ❔

• ownCloud.log

[HanaGemela]

Tested with Desktop client version ownCloud 5.0.0.11822-daily20230821 65017f windows-10.0.19045

Syncing 2 spaces with same name, one space is created with (2) at the end. ✔️

Closing as fixed and passed QA.