Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add warning in http connections #4284

Closed
10 tasks done
jesmrec opened this issue Jan 16, 2024 · 5 comments · Fixed by #4345
Closed
10 tasks done

[FEATURE REQUEST] Add warning in http connections #4284

jesmrec opened this issue Jan 16, 2024 · 5 comments · Fixed by #4345

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 16, 2024

When http:// url is set on the login view it's straight approved with no warning to the user. http connections are not secure, and it's relevant that users are warned about that issue.

This is the iOS warning:

Screenshot 2024-01-16 at 08 45 59

This is the Desktop client warning:

Screenshot 2024-01-16 at 08 47 01

TASKS

  • Research (if needed)
  • Create branch feature/add_warning_in_http_connection
  • Development tasks
    • Create a dialog alert
    • Create a function to check server info
    • Call that function when the user clicks "Continue" button in dialog alert
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/add_warning_in_http_connection into master
@michaelstingl
Copy link
Contributor

@tbsbdr @EParzefall anything you'd recommend? We can also change the existing iOS + Desktop warnings.

@jesmrec jesmrec added this to the 4.3 - Future milestone Jan 19, 2024
@EParzefall
Copy link
Contributor

My suggestion for all clients:

Insecure HTTP URL
The URL you provided uses HTTP rather than the encrypted HTTPS protocol. If you continue, your communication will not be encrypted.

For consistency reasons all affirmative buttons should be labeled "Continue".

@rohnsha0
Copy link

@EParzefall Shall I implement? the warnings?

@jesmrec
Copy link
Collaborator Author

jesmrec commented Jan 29, 2024

go ahead @rohnsha0

@JuancaG05
Copy link
Collaborator

Hi @rohnsha0! As it's already been some time since you don't reply, we have just assigned this issue to a member of the team, we would like to have this in our next release. In any case, feel free to work in any other non-assigned issue of our backlog! Thanks a lot 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment