Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Improve message when password policy does not match #4268

Closed
jesmrec opened this issue Dec 18, 2023 · 1 comment
Closed

[BUG] Improve message when password policy does not match #4268

jesmrec opened this issue Dec 18, 2023 · 1 comment
Assignees
Labels
p2-high Escalation, on top of current planning, release blocker
Milestone

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Dec 18, 2023

no matter if oC10 or oCIS, when password policy enabled (by default in oCIS 5.0.0+)

Steps to reproduce

  1. Create a link over any item
  2. Add a password that does not match the policy

Actual behaviour

It was not posible to share this file or folder because wrong username or password.

Expected behaviour

Server should return 403 (now oCIS returns 400) in the following response:

<?xml version="1.0" encoding="UTF-8"?>
<ocs>
  <meta>
    <status>error</status>
    <statuscode>400</statuscode>
    <message>At least 8 characters are required
at least 1 uppercase letters are required
at least 1 numbers are required
at least 1 special characters are required  !"#$%&amp;'()*+,-./:;&lt;=&gt;?@[\]^_`{|}~</message>
  </meta>
</ocs>

Error in <message> should be printed directly. It seems we are translating the error to other internal string.

@jesmrec jesmrec added the p2-high Escalation, on top of current planning, release blocker label Dec 18, 2023
@jesmrec jesmrec added this to the 4.2 - Current milestone Dec 18, 2023
@JuancaG05 JuancaG05 linked a pull request Dec 21, 2023 that will close this issue
@JuancaG05
Copy link
Collaborator

This would be kind of complicated since the content of the HTTP response's body is in JSON and we just parse XML now, it would imply changes in the core of network calls handling logic.
Closing this, working on password policy directly with capabilities:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

No branches or pull requests

3 participants