Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add placeholder icon for .docxf files #4267

Closed
7 tasks done
jesmrec opened this issue Dec 18, 2023 · 9 comments · Fixed by #4297
Closed
7 tasks done

[FEATURE REQUEST] Add placeholder icon for .docxf files #4267

jesmrec opened this issue Dec 18, 2023 · 9 comments · Fixed by #4297

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Dec 18, 2023

.docxf format will be supported by oCIS (open-with-web), so it will be usual to find such kind of files in the lists.

We should assign it a thumbnail-placeholder that is not the default one.

Screenshot 2023-12-18 at 12 59 12

TASKS

  • Research (if needed)
  • Create branch fix/add_placeholder_icon_for_docxf_files
  • Development tasks
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch fix/add_placeholder_icon_for_docxf_files into master
@jesmrec jesmrec added File list p4-low Low priority labels Dec 18, 2023
@kulmann
Copy link
Member

kulmann commented Dec 18, 2023

@michaelstingl
Copy link
Contributor

michaelstingl commented Dec 18, 2023

Icons from remixicon.com?

@jesmrec jesmrec mentioned this issue Dec 21, 2023
71 tasks
@jesmrec jesmrec added this to the 4.2 - Current milestone Jan 12, 2024
@jesmrec
Copy link
Collaborator Author

jesmrec commented Jan 19, 2024

Add also to the "New Document" menu inside the FAB

@jesmrec jesmrec added the Sprint label Jan 19, 2024
@Aitorbp Aitorbp self-assigned this Jan 23, 2024
@Aitorbp
Copy link
Contributor

Aitorbp commented Jan 24, 2024

I send you a screenshot of the docxf extension icon taken from material. It's right? @michaelstingl @kulmann @jesmrec @JuancaG05

Image

@michaelstingl
Copy link
Contributor

I send you a screenshot of the docxf extension icon taken from material. It's right? @michaelstingl @kulmann @jesmrec @JuancaG05

Could you post a link to the Google dev docs with the overview page of all available file type icons?

@kulmann
Copy link
Member

kulmann commented Jan 24, 2024

Icons from remixicon.com?

No. Usually our file type icons are taken from font awesome v5. But in this case I think @tbsbdr made custom ones.

@Aitorbp
Copy link
Contributor

Aitorbp commented Jan 24, 2024

I send you a screenshot of the docxf extension icon taken from material. It's right? @michaelstingl @kulmann @jesmrec @JuancaG05

Could you post a link to the Google dev docs with the overview page of all available file type icons?

Here you have: https://fonts.google.com/icons
Captura de pantalla 2024-01-24 a las 8 37 53

By the way, from this page we can only get the black and white colors. But from Android Studio we can change the color and customize them a little. They are also the same icons. You can see below:

Image

@tbsbdr
Copy link

tbsbdr commented Jan 24, 2024

@michaelstingl I can fiddle together this file (https://github.com/owncloud/web/blob/master/packages/web-pkg/src/helpers/resource/icon.ts) for you so that you get:
fileextensions, color and icon.
would that be helpful for you?

imo its its not so important for the user to see the exact same icon, it's okayish to see a similar icon. Color is more important for quick orientation in the fileslist i'd say.

@Aitorbp
Copy link
Contributor

Aitorbp commented Jan 26, 2024

I have changed the color of the icon to the same one that is on the website.
new_image_docxf

@JuancaG05 JuancaG05 changed the title Add placeholder icon for .docxf files [FEATURE REQUEST] Add placeholder icon for .docxf files Jan 29, 2024
@jesmrec jesmrec removed the Sprint label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants