Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Available offline files are downloaded at view and re-uploaded #4192

Open
rmk-ch opened this issue Oct 17, 2023 · 5 comments
Open

[BUG] Available offline files are downloaded at view and re-uploaded #4192

rmk-ch opened this issue Oct 17, 2023 · 5 comments

Comments

@rmk-ch
Copy link

rmk-ch commented Oct 17, 2023

Actual behaviour

On an Android tablet I mark a folder in an OCIS account to be available offline. I see that all files are downloaded and the folder appears in the available offline tab. In my case the folder only contains images.

Problem pops up after that, e.g. when viewing them or after that (without doing anything).
When viewing, they are downloaded (progress bar indicates this and it also takes a while) and even uploaded back to the server. The upload is sometimes also triggered without viewing.
After that the folder is usually marked with a red checkbox.

Note that files have not changed.

I tried this now many times also varying the selected folder and errors happens always in this or another way (after viewing or just after waiting).

Expected behaviour

When files are successfully downloaded (through available offline) they should

  1. not be re-downloaded when viewing or without doing anything
  2. not re-uploaded again afterwards

Steps to reproduce

  1. Mark folder as available offline
  2. Potentially view images within owncloud OR just wait

Can this problem be reproduced with the official owncloud server?
(url: https://demo.owncloud.org, user: test, password: test)
NO, not reproducible, working as expected.

Environment data

Android version: 10

Device model: Samsung Galaxy Tab S5e

Stock or customized system: Stock

ownCloud app version: 4.1.0 (adbe744)

ownCloud server version: OCIS 4.0.2

Logs

Web server error log

Insert your webserver log here

ownCloud log (data/owncloud.log)

owncloud.2023-10-17.log

@jesmrec
Copy link
Collaborator

jesmrec commented Oct 18, 2023

Thanks for reporting, i'll take a look.

@jesmrec
Copy link
Collaborator

jesmrec commented Oct 20, 2023

As the logs, some files are detected as changed local and remotely:

I: 2023-10-17 21:14:10:391(SynchronizeFileUseCase.kt:73) .run()Local file modification timestamp :1697570009000 and last sync date for data :1697569977599
I: 2023-10-17 21:14:10:392(SynchronizeFileUseCase.kt:74) .run()So it has changed locally: true
I: 2023-10-17 21:14:10:393(SynchronizeFileUseCase.kt:78) .run()Local etag :4c8da2c5aa654a2ce35186e10b18cba7 and remote etag :dcc050e99a9cfb778f42d065e9fdb1f6
I: 2023-10-17 21:14:10:393(SynchronizeFileUseCase.kt:79) .run()So it has changed remotely: true
I: 2023-10-17 21:14:10:394(SynchronizeFileUseCase.kt:83) .run()File Fifty Eiertütschen 2016-03-28 038.jpg has changed locally and remotely. We got a conflict with etag: dcc050e99a9cfb778f42d065e9fdb1f6

when a file changes, a sync operation is trigger to get the latest version. But this is not your case, becase you state that there is no changes.

I'm not able to reproduce with my instance, so i will ask you another log file (if posible), but checking the Log HTTP request and responses option in Logging section of Settings. If you can reproduce with an av. offline folder that contains not so many files (3 - 4 file would be ok) it will help to debug. Thanks a lot for your engagement.

@rmk-ch
Copy link
Author

rmk-ch commented Oct 21, 2023

Hi @jesmrec
Thanks for taking a look. There is definitely no change in the file (It re-uploads the whole folder eventually - without me taking even a look at each file).
I couldn't reproduce it with just 3 and then 28 pictures. So I took the whole folder again.

owncloud.2023-10-21.log

@rmk-ch
Copy link
Author

rmk-ch commented Nov 14, 2023

Hi @jesmrec
Is there any progress? Currently, the feature and in that case the owncloud solution is not usable for a few users that rely on this.

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 15, 2023

We'll implement this one to try to fix this issue and other ones. It'll be intended for following version 4.2, but it's something i can not assure totally at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants