Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Thumbnail improvements in grid view #4145

Closed
5 of 9 tasks
jesmrec opened this issue Aug 30, 2023 · 2 comments · Fixed by #4237
Closed
5 of 9 tasks

[FEATURE REQUEST] Thumbnail improvements in grid view #4145

jesmrec opened this issue Aug 30, 2023 · 2 comments · Fixed by #4237
Assignees
Labels
Estimation - 3 (M) File list p2-high Escalation, on top of current planning, release blocker
Milestone

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 30, 2023

Current behaviour / Context:

When browsing through folder structure, a request per item is sent:

/remote.php/dav/files/<username>/<filename>?x=336&y=336&c=&preview=1

response returns the thumbnail preview if exists, otherwise returns 404

Usually, servers return thumbnails for images (not every format) and txt files, but it could change.

Problem:

In grid view, images use to show the thumbnail, but the name. But, not every image format is handled by the server. So, we have some items without thumbnail nor name, weird for the user:

Screenshot 2023-08-30 at 18 20 37

Solution (please, suggest other if this one is not OK):

In grid view, if image is not previewable (request returns 404), show the file name as any other kind of file.

Also, change the thumbnail for another more descriptive one (anything in Android material??)

TASKS

  • Research (if needed)
  • Create branch feature/feature_name
  • Development tasks
    • Implement whatever
    • ...
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master

PR

  • App
  • Library (if needed)
@jesmrec jesmrec changed the title [FEATURE REQUEST] Thumbnails improvements in grid view [FEATURE REQUEST] Thumbnail improvements in grid view Aug 30, 2023
@manuelplazaspalacio manuelplazaspalacio added this to the 4.2 - Future milestone Sep 1, 2023
@michaelstingl michaelstingl added the p2-high Escalation, on top of current planning, release blocker label Nov 23, 2023
@Aitorbp Aitorbp self-assigned this Nov 28, 2023
@Aitorbp Aitorbp linked a pull request Nov 28, 2023 that will close this issue
2 tasks
@Aitorbp
Copy link
Contributor

Aitorbp commented Nov 28, 2023

Related to change the thumbnails, honestly I wouldn´t change the current imagen default, but I have found this one in Material Design that could be more descriptive:

Captura de pantalla 2023-11-28 a las 16 20 41

What do you think? More ideas or images are welcome @jesmrec @michaelstingl @tbsbdr @JuancaG05

@michaelstingl
Copy link
Contributor

What do you think? More ideas or images are welcome @jesmrec @michaelstingl @tbsbdr @JuancaG05

No change please. Nothing is broken, and I'd like to keep it consistent with the other platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimation - 3 (M) File list p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants