Introduce owncloud-library as module

[abelgardep]

Is your feature request related to a problem? Please describe.
At the moment, the android library is exported as a project and included in the app as a submodule.
https://github.com/owncloud/android-library

The android-library is kind of coupled to android code and accounts from AccountManager and it is not easy to work with it outside of the android app.

Dependencies need to be maintained in both projects, PR on both projects...

Describe the solution you'd like
The library could be included as an additional module same as owncloudDomain or owncloudData.

Could be called owncloudNetwork since it takes care of every single network request

Additional context
There is not much interest in the android-library project https://github.com/owncloud/android-library/forks

TASKS

• Research (if needed)
• Create branch feature/feature_name
• Development tasks
  • Implement whatever
  • ...
• Code review and apply changes requested
• Design test plan
• QA
• Merge branch feature/feature_name into master

PR

• App
• Library (if needed)

[abelgardep]

Hi @hannesa2, what do you think about this change?

Have u worked with the library outside of the android app?

[hannesa2]

No, I never used it outside. And to be honest, if I would use it outside, it would make no pain to use it from inside of main repo as well

[hannesa2]

Thanks for asking. You have my bless 😉

[abelgardep]

There are some facade classes that could be removed as soon as the owncloud-library is introduced as a module.

All the Services could be removed and the remote datasource would call the remote operation directly instead of using this facade https://github.com/owncloud/android-library/blob/master/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/Service.kt

Also, there are some intermediary classes like RemoteShare and RemoteCapability that are redundant and could be removed too. The response classes from Moshi could be mapped directly to model instead of the current CapabilityResponse -> RemoteCapability -> OCCapability

[hannesa2]

If you want, I can do this without loosing the history

[JuancaG05]

If you want, I can do this without loosing the history

Hi @hannesa2! That would be great! We need to do a quick revision of the whole owncloud-library, and when we're ready, I'll ping you for you to work on this if you want 👍

[jesmrec]

@hannesa2 are you still interested/available to do this one?

[hannesa2]

Yes, I could do this with ease

[jesmrec]

Yes, I could do this with ease

that'd be fantastic.

[hannesa2]

Is now the right time ?
I want to avoid a long running pull request, which causes a lot of maintenance

[jesmrec]

Is now the right time ?
I want to avoid a long running pull request, which causes a lot of maintenance

you're right. Team is now working full-time on new release. We can wait till release is done to review the PR as soon as it is ready. I will ping you at this point.

[jesmrec]

@hannesa2 all the team is now available for reviewing as soon as you send the code (if you are still interested in).

[hannesa2]

@jesmrec #4183

[jesmrec]

so fast, thanks, reviewing by the team