Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Improve UI design for pattern screen #3580

Closed
5 of 9 tasks
fesave opened this issue Mar 11, 2022 · 2 comments · Fixed by #3587
Closed
5 of 9 tasks

[FEATURE REQUEST] Improve UI design for pattern screen #3580

fesave opened this issue Mar 11, 2022 · 2 comments · Fixed by #3587

Comments

@fesave
Copy link
Contributor

fesave commented Mar 11, 2022

The passcode screen is a bit outdated in UI terms, so it would be great to perform a design improvement on it. Some mockups will be created so that we can compare among the current design and several proposals.

TASKS

  • Research (if needed)
  • Create branch feature/improve_pattern_screen
  • Development tasks
    • Add a back arrow to cancel in the toolbar
    • Align the design with the new passcode's design
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master

PR

  • App
  • Library (if needed)
@fesave fesave added this to the 2.21-current milestone Mar 11, 2022
@davcres davcres self-assigned this Mar 11, 2022
@davcres davcres linked a pull request Mar 16, 2022 that will close this issue
2 tasks
@jesmrec jesmrec added the Sprint label Mar 18, 2022
@davcres
Copy link
Contributor

davcres commented Mar 25, 2022

Hello @tbsbdr.
We are redesigning the pattern screen, and we want to ask you which option is better for tablets.

Old design First option Second option
Captura de pantalla 2022-03-25 a las 9 17 48 Captura de pantalla 2022-03-25 a las 9 17 48 Captura de pantalla 2022-03-25 a las 9 33 54

The first option is very similar to the old one but the second one leaves more space between the text and the pattern.
Maybe a third option could be join the text with the pattern of the second option.

Thank you.

@tbsbdr
Copy link

tbsbdr commented Mar 25, 2022

I would prefer the first option, because "Place Related Elements near Each Other" (https://www.nngroup.com/articles/gestalt-proximity/) and the whitespace around looks to me more noble 👑

I also support to remove "Cancel" as the primary action in this screen because it is obviously not the primary action here ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants