Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Extend lock enforcing methods to make them more flexible #3543

Closed
3 of 7 tasks
jesmrec opened this issue Feb 3, 2022 · 0 comments · Fixed by #3544
Closed
3 of 7 tasks

[FEATURE REQUEST] Extend lock enforcing methods to make them more flexible #3543

jesmrec opened this issue Feb 3, 2022 · 0 comments · Fixed by #3544

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 3, 2022

New behaviour:

  • lock_enforced will be integer with four different values:

    • 0 -> not forced (default)
    • 1 -> dialog (current behaviour). User will decide whether pattern/passcode
    • 2 -> passcode enforced
    • 3 -> pattern enforced
  • If the app is installed from scratch, the option set in lock_enforced will be applied.

  • Upgrades. When user upgrades from previous version. Here we have two options:

    • App was unlocked before. No locking method set. In this case, the expected behaviour will be the same as the clean installation.

    • App was locked before. A locking method was set in the previous version:

      • When passcode was set in the previous version:
        - If lock_enforced == 0 -> nothing happens in the start. Option visible in settings (not enforced anymore)
        - If lock_enforced == 1 -> nothing happens in the app start. Option hidden in settings (enforced, not switchable)
        - If lock_enforced == 2 -> nothing happens in the app start. Option hidden in settings (enforced, not switchable)
        - If lock_enforced == 3:
        · After unlocking the app with the existing passcode, a pattern is asked in a mandatory way (not skippable). From now on, only pattern will be used to unlock.
        · Biometrical will be also reset, but asked to be enabled after entering the correct pattern
        · Option hidden in settings (enforced, not switchable)

      • When pattern was set in the previous version:
        - If lock_enforced == 0 -> nothing happens in the start. Option visible in settings (not enforced anymore)
        - If lock_enforced == 1 -> nothing happens in the app start. Option hidden in settings (enforced, not switchable)
        - If lock_enforced == 2 ->
        · After unlocking the app with the existing passcode, a pattern is asked in a mandatory way (not skippable). From now on, only pattern will be used to unlock.
        · Biometrical will be also reset, but asked to be enabled after entering the correct passcode
        · Option hidden in settings (enforced, not switchable)
        - If lock_enforced == 3 -> nothing happens in the app start. Option hidden in settings (enforced, not switchable)

TASKS

  • Create branch feature/custom_lock_enforced
  • Development tasks
    • Implement new options due to new AC
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/custom_lock_enforced into master

PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants