Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Trigger camera uploads with different events #3315

Closed
9 tasks
abelgardep opened this issue Jul 19, 2021 · 1 comment
Closed
9 tasks

[FEATURE REQUEST] Trigger camera uploads with different events #3315

abelgardep opened this issue Jul 19, 2021 · 1 comment

Comments

@abelgardep
Copy link
Contributor

Describe the solution you'd like
Trigger camera uploads only when the device is charging. A new check should be added to the camera uploads view, so I can select if camera uploads should be triggered when the device is charging. Pretty similar to the current option: Upload only when connected to Wifi. We should take into account that when multiple constraints are specified, the work will run only when all the constraints are met.

Additional context
Camera uploads are enqueued via WorkManager, and we can select different constraints. At the moment we only use network type to select that uploads should be triggered when connected to wifi, but we can add any of them:

Constraint Description
NetworkType Constrains the type of network required for your work to run. For example, Wi-Fi (UNMETERED).
BatteryNotLow When set to true, your work will not run if the device is in low battery mode.
RequiresCharging When set to true, your work will only run when the device is charging.
DeviceIdle When set to true, this requires the user’s device to be idle before the work will run. This can be useful for running batched operations that might otherwise have a negative performance impact on other apps running actively on the user’s device.
StorageNotLow When set to true, your work will not run if the user’s storage space on the device is too low.

TASKS

  • Research (if needed)
  • Create branch feature/feature_name
  • Development tasks
    • Implement whatever
    • ...
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master

PR

  • App
  • Library (if needed)
@abelgardep
Copy link
Contributor Author

This is a duplicate of #465 but I added some context here, and it should not be so complex to add thanks to workmanager.

@jesmrec jesmrec changed the title [FEATURE REQUEST] Trigger camera uploads only when device is charging [FEATURE REQUEST] Trigger camera uploads with different events Sep 17, 2021
@jesmrec jesmrec closed this as completed Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants