Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Error handling for pattern lock #3215

Closed
8 tasks done
JuancaG05 opened this issue Apr 29, 2021 · 0 comments · Fixed by #3221
Closed
8 tasks done

[FEATURE REQUEST] Error handling for pattern lock #3215

JuancaG05 opened this issue Apr 29, 2021 · 0 comments · Fixed by #3221

Comments

@JuancaG05
Copy link
Collaborator

JuancaG05 commented Apr 29, 2021

Due to the recent change in error handling for passcode lock (#2722), in which we replaced the snackbars that displayed the error message with a new TextView with the error message (#2722 (comment)), it would be suitable to perform the same changes for pattern lock altough we don't have those visibility problems here, since they are analogous preferences. The cases are the same than for passcode lock:

Case 1

  1. Open Settings > Pattern lock
  2. Enter pattern
  3. In the 2nd try, enter a different pattern

Case 2

  1. Register a pattern correctly
  2. Close the app
  3. Open the app and enter an incorrect pattern

Case 3

  1. Register a pattern correctly
  2. Go to Pattern lock to try to remove the current pattern
  3. Enter an incorrect pattern

TASKS

  • Create branch feature/pattern_errors
  • Development tasks
    • Add a new TextView to the XML file
    • Replace Snackbar creation by printing a message in the TextView
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch fix/pattern_errors into master

PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants