Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error when virus is detected #3115

Open
jesmrec opened this issue Feb 25, 2021 · 1 comment
Open

Improve error when virus is detected #3115

jesmrec opened this issue Feb 25, 2021 · 1 comment
Labels

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 25, 2021

Check these steps out:

  1. Install files_antivirus in the server, and enable it
  2. Upload virused file (eicar.com) with the android app

Current:

Notification shows correctly that the virus was detected:

Screenshot 2021-02-25 at 09 05 24

But, the upload list shows only Upload not allowed:

Screenshot 2021-02-25 at 09 05 47

The PUT response is 403 Forbidden with Payload:

<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:o="http://owncloud.org/ns">
  <s:exception>OCA\DAV\Connector\Sabre\Exception\Forbidden</s:exception>
  <s:message>Virus Win.Test.EICAR_HDB-1 is detected in the file. Upload cannot be completed.</s:message>
  <o:retry xmlns:o="o:">false</o:retry>
  <o:reason xmlns:o="o:">Virus Win.Test.EICAR_HDB-1 is detected in the file. Upload cannot be completed.</o:reason>
</d:error>

Expected: Both notification and uploads view show the same accurate error. That should the expected behaviour for all errors.

Related: https://github.com/owncloud/icap/issues/21

@abelgardep
Copy link
Contributor

At the moment we don't save error messages:

// We don't know the specific forbidden error message because it is not being
// saved in uploads storage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants