-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] New search bar #2847
Comments
AC to discuss:
|
@abelgardep examples in other apps you’d recommend to look at? |
You can check some google apps: Drive, GPlay, Gmail for example. |
We have to be careful with this.
Filtering these lists could be an option. But, i think we should also check further options. |
Thanks @CarolinaCst!! I'm not sure how it will look like with the logo above, because the size (height) of the upper toolbar will increase. In devices with large screen could be fine, but in smaller screens the action side (file list) could be reduced a lot. If you think that showing the logo is important, how about showing it just below the searching bar, in between sorting dropdown and grid/list selector? just an idea. |
@CarolinaCst could you post examples from other apps? |
I) Top App Bars Documentation
a)Properties:
b) Measurements:
Sources: According to these preview sources: II) Proposal a) First: Extended Top App Bar and then a Regular Top App Bar
III) Second Proposal:
IV) Figma Mockup https://www.figma.com/file/EVQQcpITjVPiF4yT3eWKuf/Android-Proposals?node-id=0%3A1 V) Conclusions:
|
My thoughts:
Thanks for the awesome ideas @CarolinaCst ! |
After the Meeting of 03.11.2020, here are the following agreements:
|
copying new ACs, mockups etc... to the first message on the top |
About the uploads view
|
Some agreements after today's meeting:
|
https://www.figma.com/file/FGfiuKPrlLYzIrFL1mXsh9/Android-2?node-id=0%3A1 |
|
Talking with @abelgardep we have made the following changes:
|
i like all. Awesome! |
|
3. New Uploads improvements
|
👍 @tbsbdr What is your preference? Left or right? |
Right one seems to be more consistent with the current theme. White gap inside the toolbar is not nice, IMHO. |
Yes, right one is more appealing. 👍 Proposal from @diocas was, to make the input field more visible by highlighting it by ~20% or so. My proposal would be, to switch background to white when in search mode, but no idea if this is too fancy… |
Option 1 (preferred): Option 2:
e.g. box does it kinda this way - to me this appears to be visually disruptive, therefore wouldn't switch to white when in search mode. ❌ Option 3 (n2h):
onedrive, dropbox and google drive do it this way. n2h imho. only do it if you have some time to spare 🌈 |
@tbsbdr thanks for the feedback 👍 Excited to see it in action in the next reviews… |
Continuation of #2742
First mock up:
ACs:
Figma Mockup
https://www.figma.com/file/EVQQcpITjVPiF4yT3eWKuf/Android-Proposals?node-id=0%3A1
TASKS
PR
The text was updated successfully, but these errors were encountered: