Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] New search bar #2847

Closed
13 tasks done
abelgardep opened this issue Apr 15, 2020 · 26 comments · Fixed by #3087
Closed
13 tasks done

[FEATURE REQUEST] New search bar #2847

abelgardep opened this issue Apr 15, 2020 · 26 comments · Fixed by #3087
Assignees
Labels
Design Estimation - 5 (L) p2-high Escalation, on top of current planning, release blocker UI / UX
Milestone

Comments

@abelgardep
Copy link
Contributor

abelgardep commented Apr 15, 2020

Continuation of #2742

First mock up:

newUi_toolbar

ACs:

  • New search bar will be automatically shown without pressing lens icon (root)
  • Lens icon is gone (root)
  • Searching means filtering: only in the current folder (same behaviour as current)
  • ownCloud word in the hint must be brandable
  • If folder is not root, same UI (lens and name of the folder)
  • If folder is empty, bar is disabled (N2H)
  • Extended top bar at first and then a regular bar. Extended top bar will show the oC icon on the top
  • Search bar in all tabs but in uploads
  • Refresh account must be removed from three-dot-menu on the file list to account manager (check if it does not hurt)
  • In pickers/share with oC view, Toolbar will show the ownCloud label, the lens, but the avatar

image

Figma Mockup
https://www.figma.com/file/EVQQcpITjVPiF4yT3eWKuf/Android-Proposals?node-id=0%3A1

TASKS

  • Research (if needed)
  • Create branch new_design/search_bar
  • Development tasks
    • Implement new toolbar design
    • Connect new toolbar search view with current listeners
    • Move refresh account option to account management
    • Check icons color in account management view
    • Show avatar in root toolbar
    • Use new design in root view and old one in rest of the app
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch new_design/search_bar into master

PR

  • App
  • Library (if needed)
@abelgardep
Copy link
Contributor Author

abelgardep commented Apr 15, 2020

AC to discuss:

  1. Hint root folder -> Search in app_name (brandable)
  2. Hint other folders -> Search in folder_name
  3. What happens with uploads toolbar (search is not available there at the moment)?
  4. What happens with Av offline and shared by link toolbar?

@michaelstingl
Copy link
Contributor

@abelgardep examples in other apps you’d recommend to look at?

@abelgardep
Copy link
Contributor Author

@abelgardep examples in other apps you’d recommend to look at?

You can check some google apps: Drive, GPlay, Gmail for example.

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 21, 2020

  1. Hint root folder -> Search in app_name (brandable)

We have to be careful with this. Search in app_name can lead to confusion, because you are not searching on the whole account, only filtering the current folder.

  1. What happens with uploads toolbar (search is not available there at the moment)?
  2. What happens with Av offline and shared by link toolbar?

Filtering these lists could be an option. But, i think we should also check further options.

@jesmrec jesmrec added this to the 3.0-next milestone Apr 24, 2020
@michaelstingl michaelstingl added the p3-medium Normal priority label Sep 30, 2020
@jesmrec jesmrec added p2-high Escalation, on top of current planning, release blocker and removed p3-medium Normal priority labels Oct 13, 2020
@CarolinaCst CarolinaCst added the UX label Oct 16, 2020
@CarolinaCst
Copy link

Additional changes to the proposal:

  1. Add the Logo just above the Search bar

image

@jesmrec
Copy link
Collaborator

jesmrec commented Oct 21, 2020

Thanks @CarolinaCst!!

I'm not sure how it will look like with the logo above, because the size (height) of the upper toolbar will increase. In devices with large screen could be fine, but in smaller screens the action side (file list) could be reduced a lot.

If you think that showing the logo is important, how about showing it just below the searching bar, in between sorting dropdown and grid/list selector? just an idea.

@michaelstingl
Copy link
Contributor

  1. Add the Logo just above the Search bar

@CarolinaCst could you post examples from other apps?

@CarolinaCst
Copy link

CarolinaCst commented Oct 23, 2020

I) Top App Bars Documentation

The Top or Regular Top Bar: displays information, provides content and shows actions related on the screen. It's used for branding, screen titles, navigation and actions.

a)Properties:

  • Inside the Container the elements place are optional depending the purpose of the App.

  • Upon scrolling the top bar can remain in place, could hide and reveals again.

  • There are two bar heights varieties for mobile: regular and prominent or extended top bar.
    Prominent top app bars can be used for longer titles, imagery or to provide a stronger presence to the top app bar.

image

b) Measurements:

  • Regular Top App Bar has a 56dp while an Extended Top App Bar could have a 128 dp.

image

Sources:
App bars: Top: Material Design (Review 26.10.20): https://material.io/components/app-bars-top and
https://material.io/develop/android/components/app-bars-top
Mobile UX Design: User-Friendly Search: Nick Babich, 2016 (Review 26.10.20): https://uxplanet.org/mobile-ux-design-user-friendly-search-51e5f78f5a1e
How To Design Search For Your Mobile App: Suzanne Scacca, 2019 (Review 26.10.20): https://www.smashingmagazine.com/2019/01/design-search-mobile-app/

According to these preview sources:

II) Proposal

a) First: Extended Top App Bar and then a Regular Top App Bar

  • An Extended Top App Bar will be shown at first instance. It will contain the search bar and below it the ownCloud logo.

  • While scrolling the bar will transforms to a Regular Top Bar with the Search bar with the Wording: Search in ownCloud. The logo will consequently disappear independently if users scroll up again.

image

image

  • Here are the mockups:

image

III) Second Proposal:

  1. Google Drive
  • They use microinteractions in their Regular Top Bar to show their Logo. After this action the Regular Top Bar is displace.

  • Upon scrolling the search bar disappears and appears again.
    image

  • Microinteraction is useful to save time and space.

image

image

image

  1. Dropbox
  • The lens icon is located in a Regular Top Bar. Users need to click on the icon so the Search bar will be shown.

image

  • Users need to click on the Lens icon for the Search bar to appear. It is shown in another layout.

image

  • Only the Lens icon is shown on the Regular Top Bar.

image

  1. GMX Cloud
  • The same process like in Dropbox. The lens icon is located in a Regular Top Bar. Users need to click on the icon so the Search bar will be shown.

image

  • By clicking on the Lens Icon the Search bar will appears on another Layout.

image

IV) Figma Mockup

https://www.figma.com/file/EVQQcpITjVPiF4yT3eWKuf/Android-Proposals?node-id=0%3A1

V) Conclusions:

  • An Extended Top Bar is an option to include the ownCloud logo just at first sight. Then it will remain as a Regular Top Bar.

  • Another option is Microinteractions, it may save space and time. Showing at the beginning the ownCloud Logo and then a Regular Top Bar.

  • In order to smooth the Searching action, Drive provide a List divided by File types and Date modification. The idea of File types will be useful for our users as well.
    Example
    image

  • Add Recent Searches like in Dropbox: users may search for the same files
    image

  • However the Icon used in YouTube is better:

image

@CarolinaCst
Copy link

CarolinaCst commented Oct 26, 2020

I) What happened to the Toolbars: Uploads, Offline and Links?

  • Drive stick to a visible Search bar in all the sections of the App.
    image
    image
    image

  • Dropbox and GMX Cloud don't lead with this point since they don't use a Footer. My recommendation is to stick to the idea of Google Drive.

@jesmrec
Copy link
Collaborator

jesmrec commented Oct 27, 2020

My thoughts:

  • Top bar: showing the extended bar and then the regular bar when scrolling down likes me the most. Google has different capacities, so it's a good reference but use cases are not all the same.

  • Bottom bar: here we have different cases (@abelgardep correct me if i'm wrong):

    • Tabs "Files", "Av offline" and "Links": These tabs show the list of files, complete or filtered. The search bar could be another filter in case of a long list. This is OK
    • Tab "Uploads": this is different because it does not work with the list of files. Here, we could remove it (what should be place there instead?), or give it a different meaning (search in the list of uploads?but it is limited to only 30 items IIRC).
  • Search by other criteria: Actually "searching" means "filtering" (only works in the current folder). Ftm, i think we will use the name to filter, other criteria depend on how capable is/will be the searching API that is not integrated yet. But is good to have the example as reference

  • Recent searches: no strong opinion here, all ideas look good.

Thanks for the awesome ideas @CarolinaCst !

@CarolinaCst
Copy link

CarolinaCst commented Nov 3, 2020

After the Meeting of 03.11.2020, here are the following agreements:

  1. Search bar
  • Extended top bar at first and then a regular bar

  • Logo on top above the search bar

image

  1. Figma Mockup
    https://www.figma.com/file/EVQQcpITjVPiF4yT3eWKuf/Android-Proposals?node-id=0%3A1

  2. Footer

  • Still in consideration with new arrangements

image

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 6, 2020

copying new ACs, mockups etc... to the first message on the top

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 13, 2020

About the uploads view

  • We have to move all the stuff in the three-dot-menu somewhere to set there the avatar
  • Search does not appear. A Textview with the title replaces the search bar

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 17, 2020

Some agreements after today's meeting:

  • Uploads:

    • Show in the place of the Sort bar, a menu Options with all the actions to do: Clear X and Refresh. Icons with the options: trashbin for Clear options and another one for Retry

    • Let the Upload label as is. Replace the three-dot-menu with the avatar.

  • Avatar at the right of the Search. It leads to the Manage accounts view

  • Avatar only in the root folder. If folder is not root, back arrow + label with the name of the folder + Lens to search

  • Refresh account must be removed from three-dot.menu on the file list. Different options:

    1. Move it to the manage account. Pending to check how it works from such view.
    2. Remove it temporally. Make it automatically in the future -> requires additional development in all stages
  • In pickers view, Toolbar will show the ownCloud label, the lens, but the avatar (more ideas welcome)

  • In "Share with oC" view, Toolbar will show the ownCloud label, but the avatar (more ideas welcome)

@CarolinaCst
Copy link

CarolinaCst commented Nov 24, 2020

  1. Search Bar

image

  1. Uploads
    Options
    image

  2. Manage accounts
    image

  • Figma Mockups link:

https://www.figma.com/file/FGfiuKPrlLYzIrFL1mXsh9/Android-2?node-id=0%3A1

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 24, 2020

  1. Search bar is OK from my side

  2. Uploads/Options. I miss several options there, but i guess this is only a listing detail. In the Figma link, you set a chevron to show a dropdown list with different clearing options. I'd not go for that approach because the number of options to show is not too high to hide them directly. Of course, we can iterate and discuss to get better UX results.

  3. Manage accounts OK from my side. Pending to know how feasible is syncing the account from that view.

@CarolinaCst
Copy link

CarolinaCst commented Nov 25, 2020

Talking with @abelgardep we have made the following changes:

  1. Search bar: hamburger menu and avatar will be inside as in the example from Drive.
    image

  2. No logo: for small devices including the ownCloud logo will be too much space so the new option is to remove it completely.
    image

  3. New Icon: new icon for Clear failed
    However the options and icons still need to be discuss to be clear with their functionality since at first glance are so repetitive.
    image

  4. Figma mockup link:
    https://www.figma.com/file/FGfiuKPrlLYzIrFL1mXsh9/Android-2?node-id=0%3A1

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 25, 2020

i like all. Awesome!

@jesmrec jesmrec added the Sprint label Dec 4, 2020
@CarolinaCst
Copy link

CarolinaCst commented Dec 4, 2020

  1. Uploads changes:
  • On the "Failed" section users now have the option to "Clear" or "Retry" all the data and
    still have the possibility to delete every single file.

  • On "Uploaded" users can clear all the files

image

@CarolinaCst
Copy link

3. New Uploads improvements

image

@jesmrec jesmrec modified the milestones: 2.16-current, 2.17-next Jan 14, 2021
@abelgardep
Copy link
Contributor Author

abelgardep commented Feb 3, 2021

Current status, two options at the moment. BTW, I need to add a lens icon.

White background Keep background color
Screenshot_1611917501  Screenshot_1611917621

@michaelstingl
Copy link
Contributor

BTW, I need to add a lens icon.

👍

@tbsbdr What is your preference? Left or right?

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 4, 2021

Right one seems to be more consistent with the current theme. White gap inside the toolbar is not nice, IMHO.

@michaelstingl
Copy link
Contributor

Right one seems to be more consistent with the current theme.

Yes, right one is more appealing. 👍

Proposal from @diocas was, to make the input field more visible by highlighting it by ~20% or so. My proposal would be, to switch background to white when in search mode, but no idea if this is too fancy…

@tbsbdr
Copy link

tbsbdr commented Feb 4, 2021

Option 1 (preferred):
right one + icon does the job and is nice! 👍

Option 2:

switch background to white when in search mode (@michaelstingl )

e.g. box does it kinda this way - to me this appears to be visually disruptive, therefore wouldn't switch to white when in search mode. ❌

Option 3 (n2h):

highlighting it by ~20%

onedrive, dropbox and google drive do it this way. n2h imho. only do it if you have some time to spare 🌈

@michaelstingl
Copy link
Contributor

@tbsbdr thanks for the feedback 👍 Excited to see it in action in the next reviews…

@abelgardep abelgardep mentioned this issue Feb 5, 2021
4 tasks
@abelgardep abelgardep linked a pull request Feb 17, 2021 that will close this issue
4 tasks
@jesmrec jesmrec removed the Sprint label Mar 5, 2021
@jesmrec jesmrec removed the UX label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Estimation - 5 (L) p2-high Escalation, on top of current planning, release blocker UI / UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants