Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

night mode implementation? [ft][en] request #2512

Open
mstojanovic opened this issue Apr 3, 2019 · 8 comments
Open

night mode implementation? [ft][en] request #2512

mstojanovic opened this issue Apr 3, 2019 · 8 comments
Labels

Comments

@mstojanovic
Copy link

are there any plans to introduce a night mode for the android app? that would be a great feature/enhancement imho. unfortunately gui design is not something im good at at all (i really dont know how to pair colors) but maybe i could help a bit in the background during the implementation

@michaelstingl
Copy link
Contributor

@mstojanovic You mean a dark theme a user can select or something different? Could you elaborate? Do you know an example of an Android with this feature?

@mstojanovic
Copy link
Author

@michaelstingl yes, i was thinking about a dark theme. i dont think that should be to hard to implement (to each xml in drawable add the definitions for the themes, change the res/layout files to have a dynamic value for the layout, add a switch for the user to choose). the idea is that a user can go to e.g. the settings of the app and change the theme (background color, font color, ...). many apps offer that feature, e.g. twitter has a night mode.

@michaelstingl
Copy link
Contributor

You can already change colors if you compile your own client:

<!-- Colors -->
<color name="login_text_color">@color/white</color>
<color name="login_text_hint_color">#dddddd</color>
<color name="login_background_color">@color/owncloud_blue</color>
<color name="login_connection_text_color">@color/white</color>
<color name="login_credentials_text_color">@color/white</color>

<!-- Colors -->
<color name="owncloud_blue">#1D2D44</color>
<color name="owncloud_blue_accent">#35537A</color>
<color name="owncloud_blue_bright">#00ddff</color>

We're experimenting with more flexible theming options in the new iOS app:
owncloud/ios-app#251
I could imagine bringing similar methods to the Android app as well.

At the moment the focus of the team is to rework the architecture to make the app more reliable and future proof:
https://github.com/owncloud/android/labels/Architecture

@mstojanovic
Copy link
Author

i dont think you get my point... im aware that one can change the colors if he builds his own app. my idea is to give any user an option to choose a theme he wants to use (not to mention that darker themes can save battery life on AMOLED screens).

My problem with doing the changes is that i dont have the knowledge to make the gui visually appealing with color choices, but i do know how to do the technical part of implementing it. the goal of this issue/request is for the team members to think about it and maybe propose or point me into the direction of a official color pallet. or maybe give some community member an idea and she or he can come up with a color pallet that would work

@michaelstingl
Copy link
Contributor

Here's the iOS example:

2019-04-04 10 39 43 2019-04-04 10 39 53  2019-04-04 10 40 03 2019-04-04 10 40 21

You'll find some pointers in this file:
https://github.com/owncloud/ios-app/blob/master/ownCloud/Theming/ThemeCollection.swift

There's also an ongoing project to document the ownCloud design:
https://github.com/owncloud/owncloud-design-system

To sum it up:
I'd recommend to wait a few more weeks. Then there will be a new set of color parameters designed to work in the web UI, iOS app and Android app, and a documentation about the actual color values. Feel free to ping again to learn about the progress.

@mstojanovic
Copy link
Author

great, ty! thats all the info i needed :)

@davigonz
Copy link
Contributor

davigonz commented Nov 29, 2019

Android 10 brought the system-wide dark theme so we could refloat this, what do you think @michaelstingl ?

@michaelstingl
Copy link
Contributor

@davigonz yeah, fits well in the epic #2742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants