Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New architecture] Create public shares #2450

Closed
14 tasks done
davigonz opened this issue Feb 14, 2019 · 1 comment
Closed
14 tasks done

[New architecture] Create public shares #2450

davigonz opened this issue Feb 14, 2019 · 1 comment

Comments

@davigonz
Copy link
Contributor

davigonz commented Feb 14, 2019

Let's continue implementing the new architecture with a new use case, Create public shares for a file , following the next architecture:

owncloud android app architecture


TASKS

  • Include insert share query in OCShareDao
  • Include insert share operation in OCLocalDataSource
  • Include insert share operation OCRemoteDataSource
  • Include insert share operation in OCShareRepository
  • Include insert share function in OCShareViewmodel.
  • Connect PublicShareDialogFragment with OCShareViewmodel to insert shares.
  • Error handling, adapt ErrorMessageAdapter
  • Use room implementation in Content Provider to insert shares
  • Tests:
    • OCLocalDataSource
    • OCRemoteDataSource
    • OCShareRepository
    • OCShareViewModel
    • UI tests

PR

QA

Checks performed after automatic tests: owncloud/android-library#240 (comment)

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 9, 2019

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants