Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New architecture] Get public shares for a file #2403

Closed
22 tasks done
davigonz opened this issue Dec 19, 2018 · 0 comments
Closed
22 tasks done

[New architecture] Get public shares for a file #2403

davigonz opened this issue Dec 19, 2018 · 0 comments

Comments

@davigonz
Copy link
Contributor

davigonz commented Dec 19, 2018

Get public shares for a file is the first use case to start implementing #2351 , following the next architecture:

1 1 get public shares for file

Thanks to the ViewModel and LiveData , the shares shown in the view will be binded to the database, updating them automatically when a new change is detected.


TASKS

  • Include needed dependencies: Kotlin, room, lifecycle, testing...
  • Create Share entity
  • Create ShareDAO with query to get public shares for a file
  • Use LiveData in ShareDAO
  • Implement Room database
  • Create ShareRepository
  • Create ShareViewModel
  • Connect SharesFragment with ViewModel to retrieve automatically the public shares.
  • Observe shares and errors with livedata
  • Error handling
  • Expose shares stored in room by using Content Provider.
  • Add additional state (LOADING) to show loading dialog.
  • Database migration
  • Tests:
    • ShareContentProvider
    • OCLocalDataSource
    • OCShareDAO
    • OCRemoteDataSource
    • OCShareRepository
    • NetworkBoundResource
    • OCShareViewModel
    • UI tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants