Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide FAB on multi select #1404

Closed
AndyScherzinger opened this issue Jan 6, 2016 · 8 comments
Closed

Hide FAB on multi select #1404

AndyScherzinger opened this issue Jan 6, 2016 · 8 comments

Comments

@AndyScherzinger
Copy link
Contributor

following up on the discussion in #1346 I was thinking it makes sense to hide the FAB when the multi select is active and show it again when multi select has been done.

Pro:

  • it removed the then unnecessary FAB since it has no actions for a multi select and could be considered clutter at this very moment

Con:

  • show/hide might be confusing since it doesn't add extra functionality and might feel jumpy

Since I am not a UI/UX expert looping in @jancborchardt and also @tobiasKaminsky since it relates to the multi select discussion. What do you think? Personally I would hide it during multi select simply to "see" a list and nothing else :)

@tobiasKaminsky
Copy link
Contributor

Would be fine for me.

@AndyScherzinger
Copy link
Contributor Author

Would we also want a mechanism like "hide on scroll down" and "show again on scroll up"? I am just asking since some apps do this and this should be not to hard to implement observing the scrolling I guess. Just an idea though and I haven't tried to implement it yet, so no idea if and how easy this could be implemented, but like I said, it shouldn't be to hard to do I guess.

@jancborchardt what do you think about the two ideas/proposals

@tobiasKaminsky
Copy link
Contributor

No, I think this would result in a flickering show/hide of the FAB menu.
So we should stay just with your first idea.

@AndyScherzinger
Copy link
Contributor Author

Okay, sounds fine to me. Any comment @jancborchardt?

@AndyScherzinger
Copy link
Contributor Author

pinging @jancborchardt again for his 2 cents ;)

@AndyScherzinger AndyScherzinger self-assigned this Jan 9, 2016
@jancborchardt
Copy link
Member

Ah sorry – yeah I also think your first proposal of simply hiding the fab on multiselect is the best way to go.

@AndyScherzinger
Copy link
Contributor Author

OK! Thanks for the Feedback. I'll change it accordingly then :)

@AndyScherzinger
Copy link
Contributor Author

Implemented, see cca2e60 now part of the multi select issue / PR #899 / #1176

@AndyScherzinger AndyScherzinger removed their assignment Mar 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants