-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid view: Change columns with pinch zoom (like google fotos) #1402
Comments
I would rather not have an option for it as it’s something the app should take care of and be properly designed. We currently do a nice job of adjusting to portrait and landscape (3 columns in portrait on my device, and 5 in landscape). |
Hm...What if you want to browse your images really quick? Then it would be great that one can adjust the column number... |
@tobiasKaminsky I would prefer just pinch zoom on the grid (like you have it in the gallery). No need for sliders and most intuitive. But I agree with @jancborchardt that it needs to be properly designed and it is not that easy. |
@cornzy pinch zoom? In which gallery? I have never seen this. |
@tobiasKaminsky never seen or never tried ;) I had it in Sony's gallery app, now with my galaxy s6 in Samsung Gallery and even in Google Foto. |
Google foto is doing a great job. |
Hm, sounds ok. We definitely need to set sensible max and min values as well as zoom steps. What does Google Photo do? |
Google Photos zooms time and size: |
Ah ok, same as iPhoto on iOS then, grouping by event/location/time. |
Exactly. We do not have any grouping at all at the moment and I guess if we would like to introduce this we could only do time since anything else would be something that needs a lot of processing and if so should be something done on the server side (if ever). The other thing would be that we would have to add Headers to the grid view so the UI for images/videos would differ from any other. |
Yeah. But in any case I don't see this as a high priority because the default is pretty good atm. |
My idea was to "just" adjust the size to see more images at once. Nothing more, nothing less. |
Ok, then just to answer any spec questions in case you want to dive in :)
Sounds good? |
@jancborchardt
|
Update: The zoomed grid is being remembered for all grids, but only for the current app session. If one restarts/force closes the app it is set to default column size 3 again. |
Good stuff. Except I would say that the remembering should be done permanently or not at all. Otherwise it's quite confusing when you restart. |
@jancborchardt this is now implemented. |
@michaelstingl this feature looks interesting and is still used by Google Photos, have a look And there's a PR (#1466) with the implementation that we could try to merge or at least adapt its code to our current app. Reopen it? |
Looks amazing 👍 |
currently it is hardcoded to three colums if I remember correctly.
What about a slider which changes this directly between 3 and 10 (or something higher)?
@jancborchardt Where can we put this? It should be directly in the grid view? Behind the three dots?
The text was updated successfully, but these errors were encountered: