Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

purpose of OC_X_REQUEST_ID ? #200

Closed
hannesa2 opened this issue Oct 25, 2018 · 3 comments
Closed

purpose of OC_X_REQUEST_ID ? #200

hannesa2 opened this issue Oct 25, 2018 · 3 comments
Assignees
Milestone

Comments

@hannesa2
Copy link
Contributor

A general question concerning

addHeaderForAllRequests(OC_X_REQUEST_ID, RandomUtils.generateRandomUUID());

Why do it needs a unique number OC_X_REQUEST_ID here and client don't save or handle it.
So from the client side there is no need doing it here. That means only server needs it ?
If yes, the server can give himself the number too ?

@michaelstingl
Copy link
Contributor

@hannesa2 see related owncloud/android#2055

The client should write the X-REQUEST-ID to the log. It is also shown in the owncloud.log from servers 10.0.4+ and it can de displayed in the web server logs and in debug logs from infrastructure like loadbalancers or firewalls. This way it's easier to debug issues that result in weird client behaviour, but are caused by server misconfiguration or buggy infrastructure.

@hannesa2
Copy link
Contributor Author

To make it work properly, you need #201

@davigonz
Copy link
Contributor

You are right @hannesa2 , we didn't notice that, thanks!

@davigonz davigonz added this to the 0.9.21 milestone Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants