Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automations in activity stream #942

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Mar 31, 2021

These adjustments properly handle the activity stream for actions that were triggered by an automation (like the workflow app e.g.). They require the changes from owncloud/core#38605 and https://github.com/owncloud/workflow/pull/255 to work.

Needed for: https://github.com/owncloud/enterprise/issues/4222

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2021

CLA assistant check
All committers have signed the CLA.

@AlexAndBear AlexAndBear force-pushed the workflow-activity-enhancements branch from 18dac6f to 9152a62 Compare March 31, 2021 07:47
@JammingBen JammingBen changed the title enhancement Automations in activity stream Mar 31, 2021
@JammingBen JammingBen marked this pull request as ready for review March 31, 2021 11:50
@AlexAndBear AlexAndBear requested a review from jvillafanez April 6, 2021 16:42
@AlexAndBear AlexAndBear force-pushed the workflow-activity-enhancements branch 2 times, most recently from b6ef3be to 9e0f61a Compare April 9, 2021 07:37
@AlexAndBear AlexAndBear mentioned this pull request Apr 9, 2021
43 tasks
Copy link
Author

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lorem ipsum

@@ -45,6 +45,9 @@ config = {
'chrome',
'firefox'
],
'servers': [
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore after release!

@@ -60,6 +63,9 @@ config = {
'suites': [
'apiActivity'
],
'servers': [
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restore after release!

@AlexAndBear AlexAndBear force-pushed the workflow-activity-enhancements branch from cef6b71 to 568e354 Compare April 9, 2021 09:09
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drone CI changes are OK and necessary.
I will think about where we remember these, so that we put the test matrix back after release of core 10.7.1

@phil-davis
Copy link
Contributor

After release of core, we can search all apps for min-version="10.7.1" - then find the changes to .drone.star and reverse them.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AlexAndBear AlexAndBear merged commit ee40109 into master Apr 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the workflow-activity-enhancements branch April 9, 2021 09:52
@AlexAndBear AlexAndBear added this to the 2.6.1 milestone Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants