Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx is not clearing body cache #216

Closed
krewi1 opened this issue Jul 21, 2020 · 2 comments · Fixed by #217
Closed

Nginx is not clearing body cache #216

krewi1 opened this issue Jul 21, 2020 · 2 comments · Fixed by #217
Assignees

Comments

@krewi1
Copy link

krewi1 commented Jul 21, 2020

Hello, we have found a possible regression on master branch. When request body exceeds buffer body size it is stored on disk and never cleared up, which results into possible storage problems.
Here is repo with minimal setup. Nginx is configured to store data in /tmp folrder. There is for sure possibility that error is in configuration. But we didn't found it. We have fallbacked to version v1.0.1. Fallback is tested in branch fix.

@martinhsv
Copy link
Contributor

Hi @krewi1 ,

Thanks for the report.

As you suggest, I cannot rule out a configuration issue, but, like you, I don't immediately see a problem there either.

On the other hand, the post-v1.0.1 commit 83682d2 may have caused an unintended side-effect like what you describe.

If you're interested, you could consider confirming that commit is indeed the cause of the difference in behaviour (i.e. try using both versions of the code both pre- and post- that commit).

@martinhsv martinhsv self-assigned this Jul 21, 2020
@krewi1
Copy link
Author

krewi1 commented Jul 21, 2020

Well yeah i have just tested it and it seems that that commit is problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants