From d7101e13685efd7e7c9f808871b202656a969f4b Mon Sep 17 00:00:00 2001 From: Andrei Belov Date: Wed, 9 Jan 2019 08:23:11 +0300 Subject: [PATCH] Tests: adjust TODO after improving configuration merging in library See https://github.com/SpiderLabs/ModSecurity/pull/1990 for details. --- tests/modsecurity-config-merge.t | 4 ---- tests/modsecurity-request-body.t | 4 ---- 2 files changed, 8 deletions(-) diff --git a/tests/modsecurity-config-merge.t b/tests/modsecurity-config-merge.t index 92c9698..5f22aa6 100644 --- a/tests/modsecurity-config-merge.t +++ b/tests/modsecurity-config-merge.t @@ -162,9 +162,6 @@ $t->plan(10); like(http_get_body('/', 'GOOD BODY'), qr/TEST-OK-IF-YOU-SEE-THIS/, "http level defaults, pass"); like(http_get_body('/', 'VERY BAD BODY'), qr/403 Forbidden/, "http level defaults, block"); -TODO: { -local $TODO = 'not yet, see https://github.com/SpiderLabs/ModSecurity/pull/1990'; - like(http_get_body('/modsec-disabled', 'VERY BAD BODY'), qr/TEST-OK-IF-YOU-SEE-THIS/, "location override for SecRuleEngine, pass"); like(http_get_body('/nobodyaccess', 'VERY BAD BODY'), qr/TEST-OK-IF-YOU-SEE-THIS/, "location override for SecRequestBodyAccess, pass"); like(http_get_body('/bodylimitprocesspartial', 'BODY' x 33), qr/TEST-OK-IF-YOU-SEE-THIS/, "location override for SecRequestBodyLimitAction, pass"); @@ -174,7 +171,6 @@ like(http_get_body('/server/modsec-disabled', 'VERY BAD BODY'), qr/TEST-OK-IF-YO like(http_get_body('/server/nobodyaccess', 'VERY BAD BODY'), qr/TEST-OK-IF-YOU-SEE-THIS/, "server override for SecRequestBodyAccess, pass"); like(http_get_body('/server/bodylimitprocesspartial', 'BODY' x 33), qr/TEST-OK-IF-YOU-SEE-THIS/, "server override for SecRequestBodyLimitAction, pass"); like(http_get_body('/server/bodylimitincreased', 'BODY' x 64), qr/TEST-OK-IF-YOU-SEE-THIS/, "server override for SecRequestBodyLimit, pass"); -} ############################################################################### diff --git a/tests/modsecurity-request-body.t b/tests/modsecurity-request-body.t index a792dbd..2d71c81 100644 --- a/tests/modsecurity-request-body.t +++ b/tests/modsecurity-request-body.t @@ -166,13 +166,9 @@ like( 'POST with auth_request (request size < client_header_buffer_size), no preread' ); -TODO: { -local $TODO = 'not yet'; - foreach my $method (('GET', 'POST', 'PUT', 'DELETE')) { like(http_req_body($method, '/bodylimitrejectserver', 'BODY' x 33), qr/403 Forbidden/, "$method request body limit reject, block (inherited SecRequestBodyLimit)"); } -} ###############################################################################