By default sidebar should be hidden.

[sylvia43]

It's extremely annoying to have the sidebar pop up any time I open a new tab. Should it be closed by default? Or at least give the user an option to have it closed by default?

[badboy]

👍 for closed-by-default

[athaeryn]

I agree, even just as an option this would be nice.

[RasmusWL]

👍

[shsu]

👍

[achikin]

+1

[sylvia43]

@achikin You have to do :+1: to make a 👍.

[athaeryn]

Looks like this has already been brought up and is being worked on: #15

[sylvia43]

Oh oops... I missed that...

[johnduhart]

Please! 👍

[sylvia43]

This bothers me a ton

[buunguyen]

Haha, folks, I get it. Let me clarify the current behavior and the change I'm making.

Currently the tree automatically pop outs when:

1. First time navigating to GitHub after installing the extension
2. When it's previously expanded
3. When API limit is hit or you're accessing a private repo, it pops out to ask for access token [1]

I think 1 is necessary because if not showing it by default after installing, I'm sure many people will wonder where the extension is.

Number 2, I sort of sitting on the fence. I personally just want it expanded until I explicitly close it - that's how I work with IDEs, I always want to see the tree. But I can see others might not want so.

I think a good solution is having an option, something like "Collapse by default". Not a big change but requires thought on the UI. (Anyone wants to submit a pull for this?)

Another option is implementing a key-binding that allow one to quickly toggle the state. This is a simpler change and useful regardless (it's requested in another thread), so I'll give this higher priority.

As for the number 3, I think it's a bad idea and I'll turn remove this behavior.

Let me know what you think.

[1] there's a bug that Octotree thinks you're accessing a private repo while in fact it's not even a repo. (Unfortunately, I currently know of no good way to tell between the two, as GitHub API returns 404 in both cases.) For example when navigating to /blog/some-post, it thinks you're accessing a repo name some-post by user blog. This particular bug with blog was fixed although there could be more corner cases.

[sylvia43]

1: Good idea, maybe also add a little arrow to show how to close it "Click to close."
2: I disagree with this one, but maybe you could add a checkbox "Open by default."
3: I disagree with this one completely. If the user wants it open they can open it and enter a token.

[mkeeter]

👍 for making it not pop out for private repos: I use a bunch of private repos at work and don't want to give octotree an access token, so having it constantly pop up is obnoxious.

[buunguyen]

Ok, everyone, I'm convinced. It will be closed by default, if you want it open, click the button or press a short key. I'm in the middle of a bunch of other things, so if somebody want to implement the keybinding, please go ahead, I can totally use a pull request here.

[buunguyen]

Fixed. Now it only shows the first time after installation, then will never automatically pop out. You either click the toggle button or press cmd+b or ctrl+b.

If you can pull latest, give it a try and let me know your feedback as to this new behavior works better or not, I really appreciate it. I want this to be thoroughly tried before pushing to Chrome Store as this changes the way people use Octotree.

I do have a concern for first time users. They install the extension, navigate to GitHub, the tree shows (nice!); before they have a chance to learn about the toggle button, they navigate to another page, never to see the Octotree again. I have grown a few gray hairs thinking about this scenario. What do you think?

In the mean time, reopen the issue, until I feel very comfortable that the current behavior is desirable and welcome by existing/new users.

[sylvia43]

The arrow is there, and you could add a pop-up message...

[buunguyen]

I guess we could do something like that until the setting pane is implemented. Add an issue here: #84. This thread is closed now.