Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mrc): add order config/summary component #15056

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

darsene
Copy link
Contributor

@darsene darsene commented Jan 22, 2025

ref: MANAGER-16647

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-16647
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Add a component to wrap the order of a new product when it uses express order

image

Firt of all, the order configuration part should be provided as a children of <Order.Configuration>

image

Once order configuration is OK, by clicking on order button, a summary is displayed while opening a new tab with the express order (provided by the given link)

image

Product label can be overridden otherwise it will be service by default

Tracking and navigation routing could be provided by all the event button props

Related

Github issue : #15068

@darsene darsene requested review from a team as code owners January 22, 2025 16:45
@darsene darsene force-pushed the feat/MANAGER-16647 branch 2 times, most recently from 350022f to a1223e7 Compare January 22, 2025 17:02
@darsene darsene force-pushed the feat/MANAGER-16647 branch from a1223e7 to 5c54b92 Compare January 22, 2025 17:12
tibs245
tibs245 previously approved these changes Jan 23, 2025
hbelkhir
hbelkhir previously approved these changes Jan 27, 2025
stif59100
stif59100 previously approved these changes Jan 27, 2025
@antleblanc antleblanc dismissed stale reviews from stif59100 and hbelkhir via bdb6309 January 27, 2025 17:29
@darsene darsene force-pushed the feat/MANAGER-16647 branch 2 times, most recently from ab6b547 to c53e69a Compare January 27, 2025 17:50
rjamet-ovh
rjamet-ovh previously approved these changes Jan 28, 2025
ref: MANAGER-16647

Signed-off-by: David Arsène <[email protected]>
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@darsene darsene merged commit c198439 into develop Feb 3, 2025
13 of 16 checks passed
@darsene darsene deleted the feat/MANAGER-16647 branch February 3, 2025 13:24
fredericvilcot pushed a commit that referenced this pull request Feb 5, 2025
ref: MANAGER-16647

Signed-off-by: David Arsène <[email protected]>
selm3n pushed a commit that referenced this pull request Feb 6, 2025
ref: MANAGER-16647

Signed-off-by: David Arsène <[email protected]>
Steffy29 pushed a commit that referenced this pull request Feb 7, 2025
ref: MANAGER-16647

Signed-off-by: David Arsène <[email protected]>
lionel95200x pushed a commit that referenced this pull request Feb 12, 2025
ref: MANAGER-16647

Signed-off-by: David Arsène <[email protected]>
ppprevost pushed a commit that referenced this pull request Feb 12, 2025
ref: MANAGER-16647

Signed-off-by: David Arsène <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants