From 1cb39a105abd29815b596ae79f38d1a45f42aa92 Mon Sep 17 00:00:00 2001
From: Frederic Espiau <frederic.espiau@corp.ovh.com>
Date: Tue, 3 Mar 2020 08:49:24 +0100
Subject: [PATCH] build: add plugin to sort imports automatically

Signed-off-by: Frederic Espiau <frederic.espiau@corp.ovh.com>
---
 .eslintrc.js | 13 ++++++-------
 package.json |  1 +
 yarn.lock    |  5 +++++
 3 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index 6ecff00046ac..8d89e0daac32 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -3,12 +3,8 @@ const path = require('path');
 module.exports = {
   root: true,
   parser: 'babel-eslint',
-  plugins: [
-    'angular',
-    'markdown',
-    'prettier',
-  ],
-  extends: ['airbnb-base', 'prettier'],
+  plugins: ['angular', 'markdown', 'prettier', 'simple-import-sort'],
+  extends: ['airbnb-base', 'prettier', 'plugin:import/recommended'],
   env: {
     'angular/mocks': true,
     browser: true,
@@ -17,7 +13,10 @@ module.exports = {
   rules: {
     'no-bitwise': ['error', { allow: ['~'] }],
     'import/no-extraneous-dependencies': ['error', { devDependencies: true }],
-    'import/no-unresolved': 0,
+    'import/no-unresolved': 'off',
+    'simple-import-sort/sort': 'error', // sorts imports automatically
+    'sort-imports': 'off', // must be turned off for 'simple-import-sort/sort' to work fine
+    'import/order': 'off', // must be turned off for 'simple-import-sort/sort' to work fine
     'prettier/prettier': 'error',
   },
   settings: {
diff --git a/package.json b/package.json
index a7146b0d437e..8e8a5b337c96 100644
--- a/package.json
+++ b/package.json
@@ -50,6 +50,7 @@
     "eslint-plugin-import": "^2.18.2",
     "eslint-plugin-markdown": "^1.0.0",
     "eslint-plugin-prettier": "^3.1.1",
+    "eslint-plugin-simple-import-sort": "^5.0.2",
     "esm": "^3.2.25",
     "execa": "^2.0.5",
     "find-free-port": "^2.0.0",
diff --git a/yarn.lock b/yarn.lock
index 297c8a5ba833..5a550339911a 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -7153,6 +7153,11 @@ eslint-plugin-prettier@^3.1.1:
   dependencies:
     prettier-linter-helpers "^1.0.0"
 
+eslint-plugin-simple-import-sort@^5.0.2:
+  version "5.0.2"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-simple-import-sort/-/eslint-plugin-simple-import-sort-5.0.2.tgz#43b5c4ab5affa2dd8481ef40216c71723becd2e2"
+  integrity sha512-YPEGo7DbMANQ01d2OXlREcaHRszsW8LoUQ9mIjI7gXSdwpnWKfogtzL6FiBfDf1teCBx+AdcjcfDXSKpmhTWeA==
+
 eslint-rule-docs@^1.1.5:
   version "1.1.167"
   resolved "https://registry.yarnpkg.com/eslint-rule-docs/-/eslint-rule-docs-1.1.167.tgz#c569599c05d3f4a337d05907ea0ce525803e3d14"