Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases need to be made Atomic #4

Closed
joneubank opened this issue Aug 20, 2018 · 2 comments
Closed

Releases need to be made Atomic #4

joneubank opened this issue Aug 20, 2018 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@joneubank
Copy link
Contributor

Issuing a release to an Alias where there were no indexes matching the release ID resulted in a 500 error. Before failing, Rollcall removed indexes from the alias before checking that the new indexes to replace with exists.

Need preflight checks to pass before updating alias.

@andricDu andricDu added bug Something isn't working enhancement New feature or request labels Aug 20, 2018
@andricDu
Copy link
Contributor

Additionally, we need to take into account the concurrency of multiple requests in flight. We should avoid two concurrent requests making modifications at the same time.

One possible way of doing this would be to use an AtomicReference holding the last run release/removal and using synchronized either on the method doing the work or possible on the AtomicReference itself.

@andricDu
Copy link
Contributor

andricDu commented Aug 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants