Add support wechat open platform. #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new Application([
...
'open_platform' => [
'app_id' => 'component_appid',
'access_token' => 'component_access_token'
],
]) |
overtrue
reviewed
Dec 1, 2016
| @@ -46,6 +46,7 @@ public function register(Container $pimple) | |||
| $socialite = (new Socialite( | |||
| [ | |||
| 'wechat' => [ | |||
| 'open_platform' => $pimple['config']['open_platform'], | |||
There was a problem hiding this comment.
应该要检查是否存在 open_platform，因为不是大家都用开放平台
There was a problem hiding this comment.
在socialite那里WechatProvider->isOpenPlatform() 检测了下
There was a problem hiding this comment.
没，我是说 PHP 会报 undefined index open_platform
There was a problem hiding this comment.
好像不存在open_platform会返回null，会报错吗？😳
There was a problem hiding this comment.
哦，对，$pimple['config'] 是对象，那没问题
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration.