card module. #464
Merged
card module. #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @return string $api_ticket api_ticket | ||
| */ | ||
| public function cardApiTicket($jus = false) |
|
@wangniuniu 命名规范有问题，变量，方法请统一使用驼峰 |
| * | ||
| * @return string | ||
| */ | ||
| public function showQrCode_Url($ticket) |
|
|
||
| $type = strtolower($cardType); | ||
|
|
||
| $card_info = []; |
|
这可以是篇 PR 教程示范了 😂 |
| * | ||
| * @return array | ||
| */ | ||
| public function getCardList($openid, $cardId = '') |
There was a problem hiding this comment.
这里我有点疑问（因为我对卡券 API 不是太熟悉）这里既然是获取卡券列表，为啥还有一个可选的 $cardId 呢？
There was a problem hiding this comment.
用于获取用户卡包里的，属于该appid下所有可用卡券，包括正常状态和未生效状态。
卡券ID。不填写时默认查询当前appid下的卡券。
一张卡券 一个 用户 可以 领取 多张 每张的 code 不一样
|
@jinchun 这么巧，你也在此观光啊 |
| public function modifyStock($cardId, $stock = 'increase', $value = 0) | ||
| { | ||
| $params = []; | ||
| $params['card_id'] = $cardId; |
There was a problem hiding this comment.
$params = [];
$params['card_id'] = $cardId;可以考虑合并为：
$params = [
'card_id' => $cardId,
];
|
@wangniuniu 加油，实在不好意思提得有点多，为了保证代码风格一致，希望不至于让你烦到不想改了。:smile: |
|
@overtrue 我正在改、、所以没有及时回复，受教了。哈哈 |
|
@wangniuniu 妞妞童鞋 赞~~~ |
|
@tianye 还请大神们多多指教 |
| $type = strtolower($cardType); | ||
|
|
||
| $cardInfo = []; | ||
| $cardInfo['base_info'] = $baseInfo; |
There was a problem hiding this comment.
- 第 97 行
$card改为$params； - 代码合并
$cardInfo = [];
$cardInfo['base_info'] = $baseInfo;这两行请合并：
$card = [
'base_info' => $baseInfo,
];
|
@wangniuniu 我看改得快差不多了，然后你可以在 PR 后观注下图的状态：
前面有红叉的表示不通过，点击后面的 |
|
@wangniuniu 然后有一个东西叫 PHP-CS-Fixer，它可以纠正你代码里的代码规范问题，比如对齐，留白这些简单的。当然最好还是看一下它修复了什么，这样便于以后写代码的时候就正确的写。 |
|
@overtrue 好的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
卡券相关接口