Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

加入摇一摇红包类,红包类提升至Overtrue命名空间 #160

Merged
merged 7 commits into from
Nov 20, 2015
Merged

加入摇一摇红包类,红包类提升至Overtrue命名空间 #160

merged 7 commits into from
Nov 20, 2015

Conversation

tianyong90
Copy link
Contributor

1、经考虑将红包类LuckMoney从原Overtrue/Payment提升至Overtrue命名空间
2、红包多处常量命名调(不影响原有的外部调用)
3、红包类加入预下单接口
4、加入摇一摇红包类

Ps. 摇一摇红包类中创建红包活动,查询红包活动以及设置红包活动开启状态接口经测试正常。录入红包信息接口始终报错……再三检查发送数据格式,与文档中一致无误……不想再死磕浪费时间,公司项目也暂时放弃开发相关功能了。
此外接口中有生成用于摇红包JSAPI调用的数据包的方法,生成 的数据有效性未验证。因摇红包业务的实际使用需硬件设备支持,暂时无完成这些测试的条件。

综上,摇红包类仍不完善。若有热心同仁能完成最后的调试并进行相应的测试,那必是极好的。

/**
* 生成用于摇红包JSAPI调用的数据
*
* @param $lotteryId
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缺少参数类型

$param = array_merge($data, $defaultParam);
$signGenerator = new SignGenerator($param);
$me = $this;
$signGenerator->onSortAfter(function (SignGenerator $that use ($me)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

语法错误 $that 后面的括号没了

overtrue added a commit that referenced this pull request Nov 20, 2015
加入摇一摇红包类,红包类提升至Overtrue命名空间
@overtrue overtrue merged commit ed5767d into w7corp:2.1 Nov 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants