-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
加入摇一摇红包类,红包类提升至Overtrue命名空间 #160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/** | ||
* 生成用于摇红包JSAPI调用的数据 | ||
* | ||
* @param $lotteryId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
缺少参数类型
Conflicts: src/Wechat/Lottery.php src/Wechat/LuckMoney.php
$param = array_merge($data, $defaultParam); | ||
$signGenerator = new SignGenerator($param); | ||
$me = $this; | ||
$signGenerator->onSortAfter(function (SignGenerator $that use ($me)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
语法错误 $that 后面的括号没了
Conflicts: src/Wechat/Lottery.php src/Wechat/LuckMoney.php
Conflicts: src/Wechat/LuckMoney.php
Conflicts: src/Wechat/LuckMoney.php
Conflicts: src/Wechat/LuckMoney.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、经考虑将红包类LuckMoney从原Overtrue/Payment提升至Overtrue命名空间
2、红包多处常量命名调(不影响原有的外部调用)
3、红包类加入预下单接口
4、加入摇一摇红包类
Ps. 摇一摇红包类中创建红包活动,查询红包活动以及设置红包活动开启状态接口经测试正常。录入红包信息接口始终报错……再三检查发送数据格式,与文档中一致无误……不想再死磕浪费时间,公司项目也暂时放弃开发相关功能了。
此外接口中有生成用于摇红包JSAPI调用的数据包的方法,生成 的数据有效性未验证。因摇红包业务的实际使用需硬件设备支持,暂时无完成这些测试的条件。
综上,摇红包类仍不完善。若有热心同仁能完成最后的调试并进行相应的测试,那必是极好的。