Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复使用!=,来判断0 != null 的时候的一个bug #154

Merged
merged 3 commits into from
Nov 10, 2015

Conversation

pavlelee
Copy link

errcode = 0的时候,从bag对象获取errcode不是0而是null。
原因是0 != null 返回的是true

@pavlelee
Copy link
Author

这个bug,严重影响bag的调用,请尽快修复

@overtrue
Copy link
Collaborator

@Liv1020 请不要修改下面两个方法的注释

@pavlelee
Copy link
Author

第一个forget参数引用,没有return参数我就去除了。
其他的只是单纯代码格式,具体请讲?

@@ -222,6 +224,8 @@ public function getIterator()

/**
* @see Countable::count()
* @param int $mode
* @return int
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是实现接口,不需要单独写注释,我已经写了@see Countable::count()

@pavlelee
Copy link
Author

已经提交了

overtrue added a commit that referenced this pull request Nov 10, 2015
修复使用!=,来判断0 != null 的时候的一个bug
@overtrue overtrue merged commit 1550add into w7corp:2.1 Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants