Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use filename.hash.ext for production static assets #43

Open
synap5e opened this issue Feb 28, 2020 · 2 comments
Open

Use filename.hash.ext for production static assets #43

synap5e opened this issue Feb 28, 2020 · 2 comments
Assignees
Labels
bug Something isn't working requires-python Fixing/Completing this will require writing python code

Comments

@synap5e
Copy link
Contributor

synap5e commented Feb 28, 2020

When the css/json files are changed, they do not update in for users due to the multiple-day cache times.
image

To fix, assets should be versioned by their hash.
This could be implemented by extending url_for to read asset hashes from a json, and modify the filename if the file exists and has an entry for the requested url.
When built, the json could be generated .

@synap5e synap5e added bug Something isn't working requires-python Fixing/Completing this will require writing python code labels Feb 28, 2020
@gabbyprecious
Copy link

Hello, Is anyone assigned to it, can I jump on it?

@synap5e
Copy link
Contributor Author

synap5e commented Feb 29, 2020

Probably best if I take this one; it will require messing with the build system which only I have access to. The repo is mirrored on gitlab and uses their pipeline system for builds.

Thanks for the offer though :) Some of the other issues here might make more sense to pick up, I'll go through and make sure the tags are updated and assign myself to a few that I plan to take.

@synap5e synap5e self-assigned this Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working requires-python Fixing/Completing this will require writing python code
Projects
None yet
Development

No branches or pull requests

2 participants