Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last line of expression to debug stack frames, set display line number to begin/end as appropriate #22

Open
ronhitchens opened this issue May 1, 2017 · 2 comments
Assignees

Comments

@ronhitchens
Copy link
Member

ronhitchens commented May 1, 2017

The MarkLogic debug API breaks at both begin and end of expressions. It would be far more intuitive for users to display the editor cursor on either the first or last line of an expression as appropriate, since expressions can span many lines to include subexpresisons.

The stack returned from dgb:stack only includes the first line of the expression. But it should be possible programmatically to determine the last line of an expression.

@ronhitchens ronhitchens self-assigned this May 1, 2017
@ronhitchens
Copy link
Member Author

Code is in place now to set the last line on the returned stack frames. But the last line number is not being used yet, because the way breakpoints are currently set effectively defeats the purpose. It is not usually practical to select expressions that wrap around other expressions across multiple lines.

I created Issue #29 to provide that capability. Until then, I'm placing this in the Icebox. If/when #29 is implemented, I'll revisit this to add the breakpoint display mechanism to position to the beginning or end of an expression as appropriate.

@ronhitchens
Copy link
Member Author

Depends on #29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant