From b40d4a7b53962608dc7755ac643edaefa646df6b Mon Sep 17 00:00:00 2001 From: Carlos Muniz Date: Thu, 21 Jul 2022 14:22:22 -0400 Subject: [PATCH 1/2] feat: remove the implementation of dev runserver --- tutor/commands/dev.py | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/tutor/commands/dev.py b/tutor/commands/dev.py index 5d2caa69a3..4194f56861 100644 --- a/tutor/commands/dev.py +++ b/tutor/commands/dev.py @@ -120,37 +120,6 @@ def quickstart( ) -@click.command( - help="DEPRECATED: Use 'tutor dev start ...' instead!", - context_settings={"ignore_unknown_options": True}, -) -@compose.mount_option -@click.argument("options", nargs=-1, required=False) -@click.argument("service") -@click.pass_context -def runserver( - context: click.Context, - mounts: t.Tuple[t.List[compose.MountParam.MountType]], - options: t.List[str], - service: str, -) -> None: - depr_warning = "'runserver' is deprecated and will be removed in a future release. Use 'start' instead." - for option in options: - if option.startswith("-v") or option.startswith("--volume"): - depr_warning += " Bind-mounts can be specified using '-m/--mount'." - break - fmt.echo_alert(depr_warning) - config = tutor_config.load(context.obj.root) - if service in ["lms", "cms"]: - port = 8000 if service == "lms" else 8001 - host = config["LMS_HOST"] if service == "lms" else config["CMS_HOST"] - fmt.echo_info( - f"The {service} service will be available at http://{host}:{port}" - ) - args = ["--service-ports", *options, service] - context.invoke(compose.run, mounts=mounts, args=args) - - @hooks.Actions.COMPOSE_PROJECT_STARTED.add() def _stop_on_local_start(root: str, config: Config, project_name: str) -> None: """ @@ -163,5 +132,4 @@ def _stop_on_local_start(root: str, config: Config, project_name: str) -> None: dev.add_command(quickstart) -dev.add_command(runserver) compose.add_commands(dev) From 17fa2061daff1279f4450639d105dbc387fac107 Mon Sep 17 00:00:00 2001 From: Carlos Muniz Date: Thu, 21 Jul 2022 15:51:42 -0400 Subject: [PATCH 2/2] docs: add entry to CHANGELOG-nightly.md --- CHANGELOG-nightly.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG-nightly.md b/CHANGELOG-nightly.md index 092f962465..a96d48be89 100644 --- a/CHANGELOG-nightly.md +++ b/CHANGELOG-nightly.md @@ -9,6 +9,7 @@ When backporting changes to master, we should keep only the entries that corresp facing changes. --> +- 💥[Improvement] Remove the implementation of tutor dev runserver. (by @Carlos-Muniz) - [Bugfix] Fix MongoDB replica set connection error resulting from edx-platform's pymongo (3.10.1 -> 3.12.3) upgrade ([edx-platform#30569](https://github.com/openedx/edx-platform/pull/30569)). (by @ormsbee) - [Improvement] For Tutor Nightly (and only Nightly), official plugins are now installed from their nightly branches on GitHub instead of a version range on PyPI. This will allow Nightly users to install all official plugins by running ``pip install -e ".[full]"``. - [Bugfix] Remove edX references from bulk emails ([issue](https://github.com/openedx/build-test-release-wg/issues/100)).