Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible memory leak in watchtheme #1082

Closed
CodeWithEmad opened this issue Jun 21, 2024 · 6 comments
Closed

Possible memory leak in watchtheme #1082

CodeWithEmad opened this issue Jun 21, 2024 · 6 comments

Comments

@CodeWithEmad
Copy link
Member

CodeWithEmad commented Jun 21, 2024

When running the tutor in dev mode and making changes in the indigo theme, the watchtheme service keeps trying to compile SCSS files, causing a system freeze.

memory-leak.mp4

tutor version 17.0.4
OS: Ubuntu 22.04

@regisb
Copy link
Contributor

regisb commented Jun 21, 2024

@kdmccormick It looks like npm run watch-sass is incorrectly believing that some scss files from the indigo theme keep changing. Do you know what might cause this?

@kdmccormick
Copy link
Collaborator

kdmccormick commented Jun 21, 2024

Without having reproduced the bug yet, my first guess would be that the theme compilation is writing to a file that watch-sass is watching, creating an infinite loop. That would be a bug -- the generated CSS output should be completely ignored by the watch-sass watcher -- but it's possible I have the config wrong. I can dig in today.

@CodeWithEmad could you tell me the version numbers for tutor and tutor-indigo you're using (or commit hashes if nightly), and your edx-platform commit hash if you're bind-mounting it?

@CodeWithEmad
Copy link
Member Author

tutor==17.0.4
tutor-indigo==17.4.2

@regisb
Copy link
Contributor

regisb commented Jun 21, 2024

Oh my bad, in v17 Tutor did not make use of npm run watch-sass yet. @CodeWithEmad can you try to reproduce the issue in v18?

@kdmccormick
Copy link
Collaborator

kdmccormick commented Jun 21, 2024

Ah right, npm run watch-sass was experimental in Quince, which is why Tutor still recommended openedx-assets watch-themes in v17. The npm commands only became stable in Redwood / v18. I think this was one of the bugs that I hadn't worked out yet in Quince. I believe this is the edx-platform commit that fixed it.

@CodeWithEmad
Copy link
Member Author

Thank you so much for the explanation. I'll close this one and will try it on v18.

@github-project-automation github-project-automation bot moved this from Pending Triage to Done in Tutor project management Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants