Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for frontend-app-discussions #83

Closed
3 tasks done
Tracked by #67
arbrandes opened this issue Nov 10, 2022 · 5 comments
Closed
3 tasks done
Tracked by #67

Add support for frontend-app-discussions #83

arbrandes opened this issue Nov 10, 2022 · 5 comments
Assignees
@arbrandes
Labels
enhancement New feature or request
Milestone
Olive.1

Comments

@arbrandes
Copy link
Collaborator

arbrandes commented Nov 10, 2022 •
edited
Loading

It looks like Discussions might make it after all! Pending whether there are backports to the fixes, we should add it in, too.
@arbrandes arbrandes added this to the Olive Release Candidate milestone Nov 10, 2022
@arbrandes arbrandes self-assigned this Nov 10, 2022
@arbrandes arbrandes mentioned this issue Nov 10, 2022
Closed
17 tasks
@arbrandes arbrandes moved this to To Do - Backlog in Axim Engineering Tasks Nov 10, 2022
@arbrandes arbrandes moved this from To Do - Backlog to To Do - Prioritized for Current Sprint in Axim Engineering Tasks Nov 14, 2022
@arbrandes arbrandes moved this to In progress in Frontend Working Group Nov 21, 2022
@arbrandes
Copy link
Collaborator Author

Discussions is now confirmed to be in production at edx.org: openedx/frontend-app-discussions#358 (comment)

@regisb
Copy link
Contributor

regisb commented Nov 24, 2022

Indeed:

edx-discussions

@arbrandes arbrandes moved this from To Do - Prioritized for Current Sprint to In Progress in Axim Engineering Tasks Nov 25, 2022
@arbrandes arbrandes moved this from In Progress to Blocked in Axim Engineering Tasks Nov 30, 2022
@arbrandes arbrandes added the enhancement New feature or request label Dec 6, 2022
@arbrandes arbrandes moved this from In progress to Blocked in Build-Test-Release Working Group Dec 6, 2022
@arbrandes
Copy link
Collaborator Author

Aamir notes a known issue with legacy inline discussions vs the new MFE:

https://docs.google.com/document/d/1qj5OQAG1LsCaPVabz1AflqaYsPETXasrt4kqUufOLTU/edit#heading=h.8vdrxvgc5ofj

Not a huge deal IMHO, but I alerted Peter to include it in the release notes.

@arbrandes
Copy link
Collaborator Author

Turns out Discussions also needs runtime config support fixes. I submitted a PR to try and get it in:

openedx/frontend-app-discussions#377

@arbrandes
Copy link
Collaborator Author

Done!

Repository owner moved this from Blocked to Done in Axim Engineering Tasks Dec 9, 2022
Repository owner moved this from Blocked to Done in Build-Test-Release Working Group Dec 9, 2022
@arbrandes arbrandes moved this from In progress to Closed in Frontend Working Group Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbrandes arbrandes

Labels
enhancement New feature or request
Projects
None yet
Milestone
Olive.1
Development

No branches or pull requests
2 participants
@regisb @arbrandes