wip use wrapper for managing process #8456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @Jarred-Sumner 5 files with test failures on bun-darwin-aarch64: |
|
❌ @Jarred-Sumner 5 files with test failures on linux-x64: |
|
❌ @Jarred-Sumner 3 files with test failures on linux-x64-baseline: |
paperdave
requested changes
Jan 26, 2024
|
❌ @Jarred-Sumner 4 files with test failures on bun-darwin-x64: |
❌🪟 @Jarred-Sumner, there are 15 test regressions on Windows x86_64
|
src/bun.js/bindings/bindings.zig
Outdated
| @@ -4553,6 +4556,12 @@ pub const JSValue = enum(JSValueReprInt) { | |||
| } | |||
|
|
|||
| pub fn get(this: JSValue, global: *JSGlobalObject, property: []const u8) ?JSValue { | |||
| if (comptime bun.Environment.isDebug) { | |||
| if (bun.ComptimeEnumMap(BuiltinName).has(property)) { | |||
at least it compiles
…arred/process-change
…arred/process-change
…arred/process-change
…arred/process-change
Jarred-Sumner
commented
Mar 9, 2024
src/which.zig
Outdated
| @@ -15,6 +15,10 @@ fn isValid(buf: *bun.PathBuffer, segment: []const u8, bin: []const u8) ?u16 { | |||
| // Like /usr/bin/which but without needing to exec a child process | |||
| // Remember to resolve the symlink if necessary | |||
| pub fn which(buf: *bun.PathBuffer, path: []const u8, cwd: []const u8, bin: []const u8) ?[:0]const u8 { | |||
| if (bin.len == 0) return null; | |||
There was a problem hiding this comment.
this diff seems to be incorrect
…les as if they were exes" This reverts commit da47cf8.
* wip * [autofix.ci] apply automated fixes * wip 2 * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Jarred Sumner <[email protected]>
cc @paperdave. Signals can be run from any thread. This causes an assertion failure when the receiving thread happens to not be the main thread. Easiest to reproduce on linux when you spawn 100 short-lived processes at once.
|
yay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds
bun.spawn.Processwhich is a reusable way to monitor spawned processesFixes: #8588
Fixes: #9211
Fixes: #8896
Fixes: #8917
Fixes: #8360
Fixes: #8357
Fixes: #8539