Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support "allowHTTP1" option in http2 #15419

Open
MrCarbone opened this issue Nov 26, 2024 · 1 comment
Open

support "allowHTTP1" option in http2 #15419

MrCarbone opened this issue Nov 26, 2024 · 1 comment
Labels
enhancement New feature or request node:http2

Comments

@MrCarbone
Copy link

MrCarbone commented Nov 26, 2024 •
edited by RiskyMH
Loading

What version of Bun is running?

1.1.37 on win64 windows10

What steps can reproduce the bug?

import { createSecureServer } from "http2";
createSecureServer({
  allowHTTP1: true,
 //and etc
});

in Node, accepts websocket connection that incoming from client. but in Bun is unaccept
@MrCarbone MrCarbone added bug Something isn't working needs triage labels Nov 26, 2024
@RiskyMH
Copy link
Contributor

RiskyMH commented Nov 26, 2024

Looks like its todo right now

bun/src/js/node/http2.ts

Lines 3191 to 3192 in f21fffd

// TODO: Fallback to HTTP/1.1
// if (options.allowHTTP1 === true) {

@RiskyMH RiskyMH added enhancement New feature or request and removed bug Something isn't working labels Nov 26, 2024
@RiskyMH RiskyMH changed the title "allowHTTP1" property of http2 not work support "allowHTTP1" option in http2 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request node:http2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RiskyMH @MrCarbone