Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Query.result #72

Open
tindzk opened this issue Nov 17, 2015 · 5 comments
Open

Rename Query.result #72

tindzk opened this issue Nov 17, 2015 · 5 comments
Milestone
2.0

Comments

@tindzk
Copy link
Collaborator

tindzk commented Nov 17, 2015

Query.result suggests that no side-effects are taking place. This is not the case. exec might be a better fit.
@tindzk
Copy link
Collaborator Author

tindzk commented Nov 17, 2015

In analogy, I'd also like to rename converted. How about query.exec().as[T]?

@darkfrog26
Copy link
Contributor

The problem with a two-step process is that the queries can't then be pre-defined to return a specific mapping whether that be a Tuple or a specific case class.

@darkfrog26 darkfrog26 added this to the 1.2 milestone Nov 23, 2015
@darkfrog26
Copy link
Contributor

I do want to change the naming conventions here, but we need to have a deeper discussion on this to figure out the right way to accomplish it.

@darkfrog26 darkfrog26 modified the milestones: 1.3, 1.2 Jan 21, 2016
@darkfrog26
Copy link
Contributor

What do you think about pushing this to 2.0? The whole framework will be changing pretty dramatically and this is already in the prototype I started mocking up for 2.0.

@tindzk
Copy link
Collaborator Author

tindzk commented Jan 27, 2016

Sure, that's fine.

@darkfrog26 darkfrog26 modified the milestones: 2.0, 1.3 Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@tindzk @darkfrog26