Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize internal event and holiday implementation #712

Closed
noxan opened this issue Aug 11, 2022 · 2 comments · Fixed by #1110
Closed

Harmonize internal event and holiday implementation #712

noxan opened this issue Aug 11, 2022 · 2 comments · Fixed by #1110
Assignees
@leoniewgnr
Labels
good first issue Good for newcomers

Comments

@noxan
Copy link
Collaborator

noxan commented Aug 11, 2022

Holidays are only a special kind of events, yet events and holidays often have two almost the same implementations. This issue's aim is to harmonize the implementations and only have a single generic implementation, removing almost duplicate code.

More information and details to follow.
@noxan noxan mentioned this issue Aug 11, 2022
Merged
@ourownstory ourownstory added this to the Next Sprint milestone Aug 23, 2022
@noxan noxan added the good first issue Good for newcomers label Dec 2, 2022
@leoniewgnr leoniewgnr mentioned this issue Dec 3, 2022
Merged
5 tasks
@leoniewgnr
Copy link
Collaborator

Can I work on this?

@noxan noxan assigned leoniewgnr and unassigned noxan Dec 4, 2022
@noxan noxan modified the milestones: Release 0.5.0, Release 0.5.1 Dec 7, 2022
@leoniewgnr leoniewgnr moved this to Backlogged in EPIC Overview Dec 21, 2022
@leoniewgnr leoniewgnr mentioned this issue Jan 11, 2023
Merged
3 tasks
@leoniewgnr
Copy link
Collaborator

This is done:) Would be great if anyone could link the pull request #1110 to this issue

@leoniewgnr leoniewgnr linked a pull request Jan 25, 2023 that will close this issue
Avoidance of duplicate code in regularisation #1110
Merged
3 tasks
@judussoari judussoari removed this from the Release 0.5.2 milestone Feb 8, 2023
@github-project-automation github-project-automation bot moved this from Backlogged to Done in EPIC Overview Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leoniewgnr leoniewgnr

Labels
good first issue Good for newcomers
Projects
EPIC Overview
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoidance of duplicate code in regularisation leoniewgnr/neural_prophet
4 participants
@noxan @ourownstory @leoniewgnr @judussoari