Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeuralProphet fit error and could not show train progress when run with vscode juypter in branch 0.5.0rc2 and master #1069

Closed
1 task done
m2kar opened this issue Dec 14, 2022 · 2 comments
Labels
type:bug Something isn't working

Comments

@m2kar
Copy link

m2kar commented Dec 14, 2022

Prerequisites

Describe the bug

NeuralProphet fit error and could not show train progress when run with vscode python extension.
version: 0.5.0rc2, master is error, 0.4.0 is ok.

To Reproduce

Steps to reproduce the behavior:

  1. Using VSCode python extension and the inside jupyter notebook feature
  2. running notebook: neural_prophet/tutorials/application-example/energy_solar_pv.ipynb
  3. After running these code lines
m = NeuralProphet(
    yearly_seasonality=3,
    weekly_seasonality=False,
    daily_seasonality=8,
    growth="off",
    learning_rate=0.1,
)
df_train, df_test = m.split_df(sf_pv_df, freq="H", valid_p=0.10)

metrics = m.fit(df_train, freq="H", validation_df=df_test, progress="plot")
  1. See error
  • attribute error

image

  • progress show abnormal:

image

Expected behavior

progress bar show normally and without attribute error.

Environement (please complete the following information):

  • Python environment : python 3.7.13 with pytorch
  • NeuralProphet version and install method: 0.5.0rc2, installed from github
  • vscode: 1.73.1 (extension python: v2022.18.2)
@noxan
Copy link
Collaborator

noxan commented Dec 21, 2022

Thanks for the feedback :)

Just a general notice: there is a final 0.5.0 release, better use it instead of the rc2.

The attribute error seems to be related to #1064 and should be fixed in the main branch, also most likely independent of the progress bar issues. Would be great if you could double check this.

Regarding the progress bar we also added a few fixes, yet I've never seen the exact issue you described. @karl-richter do you have an idea what might be happening here?

@noxan noxan added the type:bug Something isn't working label Dec 21, 2022
@noxan
Copy link
Collaborator

noxan commented Dec 23, 2022

@m2kar I can confirm the progress bar issue - it's already tracked upstream microsoft/vscode-jupyter#8552

You have to downgrade your ipywidgets<8 for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants