New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _enabled postfix for boolean variables #1052

Closed

karl-richter opened this issue Dec 7, 2022 · 1 comment

Collaborator

karl-richter commented Dec 7, 2022 •

edited

Loading

metrics_df = self._train(
                df,
                progress=bool(progress),
                metrics=bool(self.metrics),
                checkpointing=checkpointing,
                continue_training=continue_training,
                num_workers=num_workers,
)

    We should find clear names for what kind of `metrics` variable we are dealing with, e.g. `metrics_enabled` and `metrics` or `metrics_results`... 🤔

Originally posted by @noxan in #1039 (comment)

The text was updated successfully, but these errors were encountered:

karl-richter mentioned this issue

Refactored fit() interface #1039

Merged

3 tasks

Collaborator Author

karl-richter commented Feb 17, 2023

Closed by merged pull request.

karl-richter closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment