From 42c730a8266e6517b95789f91234c6d526d66565 Mon Sep 17 00:00:00 2001 From: redsummernight Date: Sat, 21 Sep 2019 15:52:28 -0400 Subject: [PATCH 1/4] AO3-5758 Add Hound rules for bundler, layout, and style --- config/.rubocop.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/config/.rubocop.yml b/config/.rubocop.yml index 12b0784d878..08fc83ed5c4 100644 --- a/config/.rubocop.yml +++ b/config/.rubocop.yml @@ -3,6 +3,15 @@ AllCops: TargetRubyVersion: 2.3 +Bundler/OrderedGems: + Enabled: false + +Layout/DotPosition: + EnforcedStyle: leading + +Layout/MultilineMethodCallIndentation: + EnforcedStyle: indented + Layout/TrailingWhitespace: Enabled: false @@ -28,6 +37,14 @@ Metrics/ModuleLength: Style/FormatStringToken: EnforcedStyle: template +Style/FrozenStringLiteralComment: + Enabled: false + +Style/GlobalVars: + AllowedVariables: + - $elasticsearch + - $rollout + # stop checking if uses of "self" are redundant Style/RedundantSelf: Enabled: false @@ -35,3 +52,6 @@ Style/RedundantSelf: # stop checking quotation marks Style/StringLiterals: Enabled: false + +Style/SymbolArray: + Enabled: false From b8de976adf731b58ea59900190d1c06e2497bcd6 Mon Sep 17 00:00:00 2001 From: redsummernight Date: Sat, 21 Sep 2019 17:23:36 -0400 Subject: [PATCH 2/4] Add Layout/IndentArray rule --- config/.rubocop.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config/.rubocop.yml b/config/.rubocop.yml index 08fc83ed5c4..5cbf3dc2c45 100644 --- a/config/.rubocop.yml +++ b/config/.rubocop.yml @@ -9,6 +9,9 @@ Bundler/OrderedGems: Layout/DotPosition: EnforcedStyle: leading +Layout/IndentArray: + EnforcedStyle: consistent + Layout/MultilineMethodCallIndentation: EnforcedStyle: indented From 2ae9728d01d5a03fc838605c782c7e205454fb30 Mon Sep 17 00:00:00 2001 From: redsummernight Date: Fri, 4 Oct 2019 23:30:42 -0400 Subject: [PATCH 3/4] Use aligned + trailing for multiline method calls --- config/.rubocop.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/.rubocop.yml b/config/.rubocop.yml index 5cbf3dc2c45..6ed620ffd23 100644 --- a/config/.rubocop.yml +++ b/config/.rubocop.yml @@ -7,13 +7,13 @@ Bundler/OrderedGems: Enabled: false Layout/DotPosition: - EnforcedStyle: leading + EnforcedStyle: trailing Layout/IndentArray: EnforcedStyle: consistent Layout/MultilineMethodCallIndentation: - EnforcedStyle: indented + EnforcedStyle: aligned Layout/TrailingWhitespace: Enabled: false From 11a1628f5af925eebd0095fb0a0f5a475209bc2a Mon Sep 17 00:00:00 2001 From: redsummernight Date: Sun, 20 Oct 2019 23:40:56 -0400 Subject: [PATCH 4/4] Use indented + leading for multiline method calls --- config/.rubocop.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/.rubocop.yml b/config/.rubocop.yml index 6ed620ffd23..5cbf3dc2c45 100644 --- a/config/.rubocop.yml +++ b/config/.rubocop.yml @@ -7,13 +7,13 @@ Bundler/OrderedGems: Enabled: false Layout/DotPosition: - EnforcedStyle: trailing + EnforcedStyle: leading Layout/IndentArray: EnforcedStyle: consistent Layout/MultilineMethodCallIndentation: - EnforcedStyle: aligned + EnforcedStyle: indented Layout/TrailingWhitespace: Enabled: false